Paths

Table of Contentst

Differential D35297

unix/dgram: inline sbappendaddr_locked() into uipc_sosend_dgram()
ClosedPublic
Actions

Authored by glebius on May 23 2022, 9:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 5, 10:42 AM

	Unknown Object (File)
	Fri, Apr 5, 10:42 AM

	Unknown Object (File)
	Fri, Apr 5, 10:42 AM

	Unknown Object (File)
	Fri, Apr 5, 10:42 AM

	Unknown Object (File)
	Fri, Apr 5, 10:42 AM

	Unknown Object (File)
	Fri, Apr 5, 10:18 AM

	Unknown Object (File)
	Feb 22 2024, 7:53 AM

	Unknown Object (File)
	Jan 28 2024, 10:54 PM

View All 52 Files

Subscribers

Details

Reviewers

Group Reviewers

network
transport

Commits

rG5dc8dd5f3ac5: unix/dgram: inline sbappendaddr_locked() into uipc_sosend_dgram()

Summary

This allows to remove one M_NOWAIT allocation and also makes it
more clear what's going on.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.May 23 2022, 9:01 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 23 2022, 9:01 PM

glebius requested review of this revision.May 23 2022, 9:01 PM

glebius added a parent revision: D35296: unix/dgram: add a specific receive method - uipc_soreceive_dgram.

Harbormaster completed remote builds in B45678: Diff 106296.May 23 2022, 9:01 PM

glebius added a child revision: D35298: unix: provide an option to return locked from unp_connectat().May 23 2022, 9:01 PM

glebius added a child revision: D35305: libc/syslog: deprecate use of "/var/run/logpriv".May 23 2022, 9:07 PM

glebius added reviewers: network, markj.May 23 2022, 9:11 PM

Note: this patch is a step towards D35303.

markj added inline comments.May 24 2022, 2:55 PM

sys/kern/uipc_usrreq.c
1169	Why NOWAIT?

glebius marked an inline comment as done.May 25 2022, 7:36 AM

glebius added inline comments.

sys/kern/uipc_usrreq.c
1169	Because in most cases a kernel thread can't sleep here.

markj accepted this revision as: markj.May 25 2022, 7:04 PM

markj added inline comments.

sys/kern/uipc_usrreq.c
1187	I would assert `from->sa_len <= MLEN` here. Should be ok because sizeof(struct sockaddr_un) is smaller than MLEN, but that could be false in some exotic situations. (Sometimes one adds extra fields to struct mbuf for debugging purposes.)

This revision is now accepted and ready to land.May 25 2022, 7:04 PM

glebius marked 2 inline comments as done.May 25 2022, 8:32 PM

glebius added a reviewer: transport.May 28 2022, 3:50 AM

Rebase

This revision now requires review to proceed.May 31 2022, 4:36 PM

Harbormaster completed remote builds in B45789: Diff 106509.May 31 2022, 4:37 PM

Rebase, variable rename. No functional changes.

Harbormaster completed remote builds in B45851: Diff 106634.Jun 4 2022, 7:12 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 24 2022, 4:11 PM

Closed by commit rG5dc8dd5f3ac5: unix/dgram: inline sbappendaddr_locked() into uipc_sosend_dgram() (authored by glebius). · Explain Why

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG5dc8dd5f3ac5: unix/dgram: inline sbappendaddr_locked() into uipc_sosend_dgram().

Revision Contents
Changeset List

Path

Size

sys/

kern/

48 lines

Diff 107355

sys/kern/uipc_usrreq.c

Loading...