Differential D35299

sockets: enable protocol specific socket buffers
ClosedPublic
Actions

Authored by glebius on May 23 2022, 9:02 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Jan 18 2025, 9:31 PM

	Unknown Object (File)
	Dec 16 2024, 4:20 PM

	Unknown Object (File)
	Dec 13 2024, 7:07 AM

	Unknown Object (File)
	Dec 9 2024, 8:39 AM

	Unknown Object (File)
	Dec 6 2024, 3:26 AM

	Unknown Object (File)
	Nov 13 2024, 8:57 PM

	Unknown Object (File)
	Nov 12 2024, 3:13 AM

	Unknown Object (File)
	Oct 30 2024, 8:34 AM

View All 75 Files

Subscribers

Details

Reviewers

Group Reviewers

network
transport

Commits

rGa4fc41423f7d: sockets: enable protocol specific socket buffers

Summary

Split struct sockbuf into common shared fields and protocol specific
union, where protocols are free to implement whatever buffer they
want. Such protocols should mark themselves with PR_SOCKBUF and are
expected to initialize their buffers in their pr_attach and tear
them down in pr_detach.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.May 23 2022, 9:02 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 23 2022, 9:02 PM

glebius requested review of this revision.May 23 2022, 9:02 PM

Harbormaster completed remote builds in B45680: Diff 106298.May 23 2022, 9:02 PM

glebius added a parent revision: D35298: unix: provide an option to return locked from unp_connectat().May 23 2022, 9:02 PM

glebius added a child revision: D35300: unix/dgram: use minimal possible socket buffer for PF_UNIX/SOCK_DGRAM.

glebius added a child revision: D35305: libc/syslog: deprecate use of "/var/run/logpriv".May 23 2022, 9:07 PM

glebius added reviewers: network, markj.May 23 2022, 9:12 PM

Note: this patch is a step towards D35303.

markj accepted this revision as: markj.May 24 2022, 3:17 PM

markj added inline comments.

sys/sys/sockbuf.h
107

This revision is now accepted and ready to land.May 24 2022, 3:17 PM

Rebase over d59bc188d652dfaa06bef9963120aa54c4c68875

This revision now requires review to proceed.May 27 2022, 3:28 PM

Harbormaster completed remote builds in B45745: Diff 106424.May 27 2022, 3:28 PM

glebius added a reviewer: transport.May 28 2022, 3:50 AM

markj accepted this revision as: markj.May 30 2022, 1:45 PM

This revision is now accepted and ready to land.May 30 2022, 1:45 PM

Closed by commit rGa4fc41423f7d: sockets: enable protocol specific socket buffers (authored by glebius). · Explain WhyJun 24 2022, 4:11 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGa4fc41423f7d: sockets: enable protocol specific socket buffers.

Revision Contents
Changeset List

Path

Size

sys/

kern/

12 lines

sys/

3 lines

86 lines

Diff 107357

sys/kern/uipc_socket.c

Loading...

sys/sys/protosw.h

Loading...

sys/sys/sockbuf.h

Loading...