sysvsem: Add a timeout argument to the semop.
ClosedPublic
Actions

Authored by dchagin on May 4 2022, 4:38 PM.

Details

Reviewers

kib
jhb

Commits

rGda7cee20aa7a: sysvsem: Add a timeout argument to the semop.
rGf04534f5c84e: sysvsem: Add a timeout argument to the semop.

Summary

For future use in the Linux emulation layer for the semtimedop syscall
split the sys_semop syscall into two counterparts and add
struct timespec *timeout argument to the last one.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 45465
Build 42353: arc lint + arc unit

Event Timeline

dchagin created this revision.May 4 2022, 4:38 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 4 2022, 4:38 PM

dchagin requested review of this revision.May 4 2022, 4:38 PM

Harbormaster completed remote builds in B45465: Diff 105677.May 4 2022, 4:38 PM

dchagin added reviewers: kib, jhb.May 4 2022, 4:39 PM

dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.

jhb accepted this revision.May 4 2022, 6:40 PM

jhb added inline comments.

sys/kern/sysv_sem.c
1353	I think this is fine, but I would maybe write this bit instead as something like: if (error != 0) { if (error == ERESTART) error = EINTR; goto done2; } I think that makes the intent clearer overall.

This revision is now accepted and ready to land.May 4 2022, 6:40 PM

kib added inline comments.May 4 2022, 10:24 PM

sys/kern/sysv_sem.c
1156	There is very similar, if not identical code, both in your recent kern_sig.c changes, and in kern_event.c::kqueue_scan(). Can it be extracted into some common helper? Also it arguably requires a comment so that people easily see how we handle timeout precision.

dchagin added inline comments.May 5 2022, 8:44 AM

sys/kern/sysv_sem.c
1156	Yes, the code is almost identical, I already thought about what you suggested. I'll do it a bit later, first I need to commit my local queue, it's too big.
1353	sure