acpi_toshiba: Use device_get_softc in attach.
ClosedPublic
Actions

Authored by jhb on Apr 20 2022, 8:17 PM.

Tags

None

Referenced Files

	F173360090: D35010.id105294.diff
	Fri, Sep 25, 10:52 AM

	F173348377: D35010.diff
	Fri, Sep 25, 9:19 AM

	F173348034: D35010.id105240.diff
	Fri, Sep 25, 9:17 AM

	Unknown Object (File)
	Thu, Sep 17, 12:20 PM

	Unknown Object (File)
	Fri, Sep 11, 11:17 PM

	Unknown Object (File)
	Thu, Sep 10, 11:40 PM

	Unknown Object (File)
	Sun, Sep 6, 4:20 PM

	Unknown Object (File)
	Sun, Sep 6, 3:24 AM

View All Files

Subscribers

None

Details

Reviewers

imp

Commits

rG7fe4c7b59e03: acpi_toshiba: Use device_get_softc in attach.
rG1ac10fa42937: acpi_toshiba: Use device_get_softc in attach.

Summary

Rather than a detour via the devclass and hardcoding unit 0.

While here, remove a check for sc being NULL. It will never be NULL
when attach is called.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Apr 20 2022, 8:17 PM

jhb created this revision.

Harbormaster completed remote builds in B45282: Diff 105240.Apr 20 2022, 8:17 PM

imp accepted this revision.Apr 20 2022, 9:26 PM

This revision is now accepted and ready to land.Apr 20 2022, 9:26 PM

Closed by commit rG1ac10fa42937: acpi_toshiba: Use device_get_softc in attach. (authored by jhb). · Explain WhyApr 21 2022, 5:31 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG1ac10fa42937: acpi_toshiba: Use device_get_softc in attach..

jhb added a commit: rG7fe4c7b59e03: acpi_toshiba: Use device_get_softc in attach..May 20 2022, 12:21 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

acpi_support/

acpi_toshiba.c

4 lines

Diff 105294

View Options

sys/dev/acpi_support/acpi_toshiba.c

acpi_toshiba: Use device_get_softc in attach.ClosedPublicActions