Page MenuHomeFreeBSD

openssh: consolidate some globally-applicable flags
Needs ReviewPublic

Authored by emaste on Sep 10 2021, 5:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 23, 12:01 PM
Unknown Object (File)
Tue, Oct 15, 12:22 PM
Unknown Object (File)
Fri, Oct 11, 9:19 AM
Unknown Object (File)
Oct 1 2024, 9:37 PM
Unknown Object (File)
Sep 30 2024, 11:21 PM
Unknown Object (File)
Sep 29 2024, 10:53 PM
Unknown Object (File)
Sep 28 2024, 10:12 AM
Unknown Object (File)
Sep 27 2024, 11:55 AM
Subscribers

Details

Reviewers
des
kevans
Summary

Pretty much all applications/libs built out of openssh define a common
set of options:

  • HAVE_LDNS is only relevant for applications that build readconf.c and

libssh, which builds getrrsetbyname off of ldns, but defining it is more
future-proof.

  • All of them include ssh_namespace.h, and include out of

crypto/openssh.

Moving these into crypto/openssh reduces the boilerplate and gives us
a central place if we run into other options like HAVE_LDNS.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Moving these into crypto/openssh

Yes, although it is somewhat odd that the build infrastructure is now split between secure/* and crypto/openssh/

crypto/openssh/Makefile.freebsd
12–13 ↗(On Diff #94938)

I think the real reason is to accommodate WITH_/WITHOUT_LDNS src.conf setting. Perhaps we should do the same with LIBWRAP from secure/usr.sbin/sshd/Makefile?

crypto/openssh/Makefile.freebsd
12–13 ↗(On Diff #94938)

Ah, good point; will do. I'll move this guy to secure/Makefile.openssh or something as well...

It seems I did something similar, in 9d63429fa16352f58037ac2aa6ddc734b25e8331
I think it still makes sense to move the HAVE_LDNS / LIBWRAP flags (and anything else left) there.

emaste updated this revision to Diff 104902.
emaste edited reviewers, added: kevans; removed: emaste.

move to ssh.mk, rebase after 9d63429fa163