Page MenuHomeFreeBSD
Differential D34799

Remove checks for __GNUCLIKE___SECTION assuming it is always true.
ClosedPublic
Actions

Authored by jhb on Apr 6 2022, 2:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 9, 1:02 PM
Unknown Object (File)
Mon, Mar 17, 8:24 AM
Unknown Object (File)
Feb 25 2025, 8:47 AM
Unknown Object (File)
Feb 24 2025, 9:50 AM
Unknown Object (File)
Feb 24 2025, 3:03 AM
Unknown Object (File)
Feb 23 2025, 10:46 PM
Unknown Object (File)
Feb 22 2025, 4:29 PM
Unknown Object (File)
Feb 3 2025, 3:34 AM
View All 89 Files
Subscribers
imp

Details

Reviewers
brooks
emaste
imp
Commits
rG9f92ef766ae0: Remove checks for __GNUCLIKE___SECTION assuming it is always true.
Summary

All supported compilers (modern versions of GCC and clang) support
this.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45024
Build 41912: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
sys/
4 lines

Diff 104665

View Options

sys/sys/linker_set.h

Show First 20 Lines • Show All 406 Lines • ▼ Show 20 Lines for (;;) {
if (avail > budget) if (avail > budget)
break; break;
} }
cmpl_invalid: cmpl_invalid:
return avail; return avail;
} }
static void
shurdUnsubmitted
Not Done
Inline Actions

Type should be on a separate line.

shurd: Type should be on a separate line.
bnxt_set_rsstype(if_rxd_info_t ri, uint8_t rss_hash_type)
{
uint8_t rss_profile_id;
rss_profile_id = BNXT_GET_RSS_PROFILE_ID(rss_hash_type);
switch (rss_profile_id) {
case BNXT_RSS_HASH_TYPE_TCPV4:
ri->iri_rsstype = M_HASHTYPE_RSS_TCP_IPV4;
break;
case BNXT_RSS_HASH_TYPE_UDPV4:
ri->iri_rsstype = M_HASHTYPE_RSS_UDP_IPV4;
break;
case BNXT_RSS_HASH_TYPE_IPV4:
ri->iri_rsstype = M_HASHTYPE_RSS_IPV4;
break;
case BNXT_RSS_HASH_TYPE_TCPV6:
ri->iri_rsstype = M_HASHTYPE_RSS_TCP_IPV6;
break;
case BNXT_RSS_HASH_TYPE_UDPV6:
ri->iri_rsstype = M_HASHTYPE_RSS_UDP_IPV6;
break;
case BNXT_RSS_HASH_TYPE_IPV6:
ri->iri_rsstype = M_HASHTYPE_RSS_IPV6;
break;
default:
ri->iri_rsstype = M_HASHTYPE_OPAQUE;
break;
}
}
static int static int
bnxt_pkt_get_l2(struct bnxt_softc *softc, if_rxd_info_t ri, bnxt_pkt_get_l2(struct bnxt_softc *softc, if_rxd_info_t ri,
struct bnxt_cp_ring *cpr, uint16_t flags_type) struct bnxt_cp_ring *cpr, uint16_t flags_type)
{ {
struct rx_pkt_cmpl *rcp; struct rx_pkt_cmpl *rcp;
struct rx_pkt_cmpl_hi *rcph; struct rx_pkt_cmpl_hi *rcph;
struct rx_abuf_cmpl *acp; struct rx_abuf_cmpl *acp;
uint32_t flags2; uint32_t flags2;
uint32_t errors; uint32_t errors;
uint8_t ags; uint8_t ags;
int i; int i;
rcp = &((struct rx_pkt_cmpl *)cpr->ring.vaddr)[cpr->cons]; rcp = &((struct rx_pkt_cmpl *)cpr->ring.vaddr)[cpr->cons];
/* Extract from the first 16-byte BD */ /* Extract from the first 16-byte BD */
if (flags_type & RX_PKT_CMPL_FLAGS_RSS_VALID) { if (flags_type & RX_PKT_CMPL_FLAGS_RSS_VALID) {
ri->iri_flowid = le32toh(rcp->rss_hash); ri->iri_flowid = le32toh(rcp->rss_hash);
/* bnxt_set_rsstype(ri, rcp->rss_hash_type);
* TODO: Extract something useful from rcp->rss_hash_type
* (undocumented)
* May be documented in the "LSI ES"
* also check the firmware code.
*/
ri->iri_rsstype = M_HASHTYPE_OPAQUE;
} }
else { else {
ri->iri_rsstype = M_HASHTYPE_NONE; ri->iri_rsstype = M_HASHTYPE_NONE;
} }
ags = (rcp->agg_bufs_v1 & RX_PKT_CMPL_AGG_BUFS_MASK) >> ags = (rcp->agg_bufs_v1 & RX_PKT_CMPL_AGG_BUFS_MASK) >>
RX_PKT_CMPL_AGG_BUFS_SFT; RX_PKT_CMPL_AGG_BUFS_SFT;
ri->iri_nfrags = ags + 1; ri->iri_nfrags = ags + 1;
/* No need to byte-swap the opaque value */ /* No need to byte-swap the opaque value */
▲ Show 20 Lines • Show All 63 Lines • ▼ Show 20 Linesbnxt_pkt_get_tpa(struct bnxt_softc *softc, if_rxd_info_t ri,
/* Get the agg_id */ /* Get the agg_id */
agg_id = (agend->agg_id & RX_TPA_END_CMPL_AGG_ID_MASK) >> agg_id = (agend->agg_id & RX_TPA_END_CMPL_AGG_ID_MASK) >>
RX_TPA_END_CMPL_AGG_ID_SFT; RX_TPA_END_CMPL_AGG_ID_SFT;
tpas = &softc->tpa_start[agg_id]; tpas = &softc->tpa_start[agg_id];
/* Extract from the first 16-byte BD */ /* Extract from the first 16-byte BD */
if (le16toh(tpas->low.flags_type) & RX_TPA_START_CMPL_FLAGS_RSS_VALID) { if (le16toh(tpas->low.flags_type) & RX_TPA_START_CMPL_FLAGS_RSS_VALID) {
ri->iri_flowid = le32toh(tpas->low.rss_hash); ri->iri_flowid = le32toh(tpas->low.rss_hash);
/* bnxt_set_rsstype(ri, tpas->low.rss_hash_type);
* TODO: Extract something useful from tpas->low.rss_hash_type
* (undocumented)
* May be documented in the "LSI ES"
* also check the firmware code.
*/
ri->iri_rsstype = M_HASHTYPE_OPAQUE;
} }
else { else {
ri->iri_rsstype = M_HASHTYPE_NONE; ri->iri_rsstype = M_HASHTYPE_NONE;
} }
ags = (agend->agg_bufs_v1 & RX_TPA_END_CMPL_AGG_BUFS_MASK) >> ags = (agend->agg_bufs_v1 & RX_TPA_END_CMPL_AGG_BUFS_MASK) >>
RX_TPA_END_CMPL_AGG_BUFS_SFT; RX_TPA_END_CMPL_AGG_BUFS_SFT;
ri->iri_nfrags = ags + 1; ri->iri_nfrags = ags + 1;
/* No need to byte-swap the opaque value */ /* No need to byte-swap the opaque value */
▲ Show 20 Lines • Show All 109 Lines • Show Last 20 Lines