x86: Defer TSC timecounter calibration
ClosedPublic
Actions

Authored by markj on Mar 4 2022, 6:27 PM.

Details

Reviewers

Commits

rG075e2779aca7: x86: Defer early TSC timecounter calibration to SI_SUB_CPU

Summary

If we can't determine the TSC frequency using CPU registers, we need to
give a chance for hyperv to register a timecounter since an emulated
8254 might not be available.

Fixes: 84369dd52369 ("x86: Probe the TSC frequency earlier")
Reported by: khng, Shawn Webb

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Mar 4 2022, 6:27 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 4 2022, 6:27 PM

markj requested review of this revision.Mar 4 2022, 6:27 PM

Harbormaster completed remote builds in B44659: Diff 103498.Mar 4 2022, 6:27 PM

emaste added a subscriber: emaste.Mar 4 2022, 6:35 PM

Works on the 10.0.20348.524 Hyper-V hypervisor, with AMD Epyc 7443 CPU.

This revision is now accepted and ready to land.Mar 4 2022, 6:42 PM

rpokala added a subscriber: rpokala.Mar 4 2022, 7:05 PM

rpokala added inline comments.

sys/x86/x86/tsc.c
269	"a chance to a" I think you're missing a verb...?

Fix a typo.

This revision now requires review to proceed.Mar 4 2022, 7:08 PM

Harbormaster completed remote builds in B44660: Diff 103502.Mar 4 2022, 7:08 PM

khng accepted this revision.Mar 4 2022, 8:50 PM

This revision is now accepted and ready to land.Mar 4 2022, 8:50 PM

Closed by commit rG075e2779aca7: x86: Defer early TSC timecounter calibration to SI_SUB_CPU (authored by markj). · Explain WhyMar 5 2022, 12:50 AM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG075e2779aca7: x86: Defer early TSC timecounter calibration to SI_SUB_CPU.

Revision Contents
Changeset List

Path

Size

sys/

x86/

tsc.c

50 lines

Diff 103515

View Options

sys/x86/x86/tsc.c

	Show First 20 Lines • Show All 409 Lines • ▼ Show 20 Lines
	FILE funopen(const void ,			FILE funopen(const void ,
	int (* _Nullable)(void , char , int),			int (* _Nullable)(void , char , int),
	int (* _Nullable)(void , const char , int),			int (* _Nullable)(void , const char , int),
	fpos_t (* _Nullable)(void *, fpos_t, int),			fpos_t (* _Nullable)(void *, fpos_t, int),
	int (* _Nullable)(void *));			int (* _Nullable)(void *));
	#define fropen(cookie, fn) funopen(cookie, fn, 0, 0, 0)			#define fropen(cookie, fn) funopen(cookie, fn, 0, 0, 0)
	#define fwopen(cookie, fn) funopen(cookie, 0, fn, 0, 0)			#define fwopen(cookie, fn) funopen(cookie, 0, fn, 0, 0)

				#if __BSD_VISIBLE
	typedef __ssize_t cookie_read_function_t(void , char , size_t);			typedef __ssize_t cookie_read_function_t(void , char , size_t);
	typedef __ssize_t cookie_write_function_t(void , const char , size_t);			typedef __ssize_t cookie_write_function_t(void , const char , size_t);
	typedef int cookie_seek_function_t(void , off64_t , int);			typedef int cookie_seek_function_t(void , off64_t , int);
	typedef int cookie_close_function_t(void *);			typedef int cookie_close_function_t(void *);
	typedef struct {			typedef struct {
	cookie_read_function_t *read;			cookie_read_function_t *read;
	cookie_write_function_t *write;			cookie_write_function_t *write;
	cookie_seek_function_t *seek;			cookie_seek_function_t *seek;
	cookie_close_function_t *close;			cookie_close_function_t *close;
	} cookie_io_functions_t;			} cookie_io_functions_t;
	FILE fopencookie(void , const char *, cookie_io_functions_t);			FILE fopencookie(void , const char *, cookie_io_functions_t);
				#endif

	/*			/*
	* Portability hacks. See <sys/types.h>.			* Portability hacks. See <sys/types.h>.
	*/			*/
	#ifndef _FTRUNCATE_DECLARED			#ifndef _FTRUNCATE_DECLARED
	#define _FTRUNCATE_DECLARED			#define _FTRUNCATE_DECLARED
	int ftruncate(int, __off_t);			int ftruncate(int, __off_t);
	#endif			#endif
	▲ Show 20 Lines • Show All 97 Lines • Show Last 20 Lines

x86: Defer TSC timecounter calibrationClosedPublicActions