amd64: Call clock_init() after finishidentcpu()
AbandonedPublic
Actions

Authored by khng on Mar 4 2022, 5:08 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 8, 5:26 PM

	Unknown Object (File)
	Tue, Nov 4, 1:14 PM

	Unknown Object (File)
	Tue, Nov 4, 1:14 PM

	Unknown Object (File)
	Tue, Nov 4, 1:12 PM

	Unknown Object (File)
	Wed, Oct 29, 11:38 PM

	Unknown Object (File)
	Oct 17 2025, 6:13 AM

	Unknown Object (File)
	Oct 11 2025, 1:52 PM

	Unknown Object (File)
	Oct 4 2025, 6:33 AM

View All 64 Files

Subscribers

imp

Details

Reviewers

markj

Summary

In a subsequent commit clock_init() will attempt to determine the TSC
frequency, and this requires that CPU identification is finalized.

MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44656
Build 41544: arc lint + arc unit

Event Timeline

khng created this revision.Mar 4 2022, 5:08 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 4 2022, 5:08 PM

khng requested review of this revision.Mar 4 2022, 5:08 PM

Harbormaster completed remote builds in B44656: Diff 103495.Mar 4 2022, 5:08 PM

In a subsequent commit clock_init() will attempt to determine the TSC frequency, and this requires that CPU identification is finalized.

Need to remove "In a subsequent commit" and change "will attempt" to "attempts".

sys/amd64/amd64/machdep.c
1456	A more conservative approach is to move the clock_init() call instead, but ok.

This revision is now accepted and ready to land.Mar 4 2022, 6:34 PM

Superseded by https://reviews.freebsd.org/D34444.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

machdep.c

3 lines

Diff 103495

View Options

amd64: Call clock_init() after finishidentcpu()AbandonedPublicActions