Use a regset for NT_ARM_VFP.
ClosedPublic
Actions

Authored by jhb on Mar 4 2022, 10:58 PM.

Details

Reviewers

emaste
andrew
markj
manu

Commits

rGd801e93ec202: Use a regset for NT_ARM_VFP.
rGadd00c381e5c: Use a regset for NT_ARM_VFP.

Summary

This includes adding support for NT_ARM_VFP for 32-bit binaries
running under aarch64 kernels both for ptrace(), and coredumps via the
kernel and gcore.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44663
Build 41551: arc lint + arc unit

Event Timeline

jhb created this revision.Mar 4 2022, 10:58 PM

Herald added a reviewer: manu. · View Herald TranscriptMar 4 2022, 10:58 PM

Herald added a subscriber: imp. · View Herald Transcript

jhb requested review of this revision.Mar 4 2022, 10:58 PM

Harbormaster completed remote builds in B44663: Diff 103509.Mar 4 2022, 10:58 PM

jhb added a parent revision: D34447: gcore: Use PT_GETREGSET to fetch NT_PRSTATUS and NT_FPREGSET..Mar 4 2022, 10:58 PM

I've tested this on 32-bit arm, still need to test 32-bit processes under aarch64.

markj accepted this revision.Mar 7 2022, 6:30 PM

This revision is now accepted and ready to land.Mar 7 2022, 6:30 PM

jhb added a parent revision: D34525: aarch64: Fix get_fpcontext32() to work on non-curthread..Mar 11 2022, 1:15 AM

jhb mentioned this in D34525: aarch64: Fix get_fpcontext32() to work on non-curthread..

Move regset handling to ptrace_machdep.c.

This revision now requires review to proceed.Mar 12 2022, 12:44 AM

Harbormaster completed remote builds in B44747: Diff 103774.Mar 12 2022, 12:44 AM

jhb added a parent revision: D34536: <sys/reg.h>: Add ELF32_REGSET..Mar 12 2022, 12:45 AM

I ended up moving the regset handling to ptrace_machdep.c. I have some other changes in flight that I'm still testing to add NT_ARM_TLS for arm/arm64 and a new NT_X86_SEGBASES for i386 and amd64 so that we can debug TLS variables in core dumps (and debug TLS for running processes for arm/arm64 in gdb) and while working on those I found it was nicer to handle register sets in ptrace_machdep.c (or in the case of i386 on amd64, ia32_regs.c).

Possibly NT_ARM_ADDR_MASK should move to ptrace_machdep.c as well eventually, but I'm going to leave that for another day.

andrew accepted this revision.Mar 14 2022, 2:47 PM

This revision is now accepted and ready to land.Mar 14 2022, 2:47 PM

markj accepted this revision.Mar 14 2022, 3:32 PM

jhb added a child revision: D34595: arm,arm64: Add a NT_ARM_TLS read-only register set..Mar 17 2022, 11:00 PM

Closed by commit rGadd00c381e5c: Use a regset for NT_ARM_VFP. (authored by jhb). · Explain WhyMar 23 2022, 8:34 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGadd00c381e5c: Use a regset for NT_ARM_VFP..

jhb added a commit: rGd801e93ec202: Use a regset for NT_ARM_VFP..May 13 2022, 5:43 PM