Differential D34447

gcore: Use PT_GETREGSET to fetch NT_PRSTATUS and NT_FPREGSET.
ClosedPublic
Actions

Authored by jhb on Mar 4 2022, 10:58 PM.

Tags

None

Referenced Files

	F170158643: D34447.diff
	Thu, Sep 3, 4:52 PM

	Unknown Object (File)
	Thu, Sep 3, 1:46 AM

	Unknown Object (File)
	Thu, Sep 3, 12:14 AM

	Unknown Object (File)
	Wed, Sep 2, 11:22 PM

	Unknown Object (File)
	Wed, Sep 2, 10:43 PM

	Unknown Object (File)
	Tue, Sep 1, 1:45 AM

	Unknown Object (File)
	Mon, Aug 31, 11:28 PM

	Unknown Object (File)
	Sun, Aug 30, 8:50 PM

Subscribers

Details

Reviewers

emaste
andrew
markj

Commits

rG6c2ea7f890b1: gcore: Use PT_GETREGSET to fetch NT_PRSTATUS and NT_FPREGSET.
rG4965ac059da1: gcore: Use PT_GETREGSET to fetch NT_PRSTATUS and NT_FPREGSET.

Summary

Add a elf_putregnote() helper to build the ELF note for a register
set. Once nice result of this approach is that this reuses the
kernel's support for generating 32-bit register sets for 32-bit
processes avoiding the need to duplicate that logic in elf32core.c.

Sponsored by: University of Cambridge, Google, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Mar 4 2022, 10:58 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 4 2022, 10:58 PM

jhb requested review of this revision.Mar 4 2022, 10:58 PM

Harbormaster completed remote builds in B44662: Diff 103508.Mar 4 2022, 10:58 PM

jhb added a parent revision: D34446: Store core dump notes for all valid register sets for FreeBSD processes..Mar 4 2022, 10:58 PM

jhb added a child revision: D34448: Use a regset for NT_ARM_VFP..

I've tested this on 32-bit arm. I will test on amd64 before committing to ensure it DTRT for both amd64 and i386 processes.

markj accepted this revision.Mar 7 2022, 6:23 PM

This revision is now accepted and ready to land.Mar 7 2022, 6:23 PM

Tested on amd64 for both i386 and amd64 processes.

Closed by commit rG4965ac059da1: gcore: Use PT_GETREGSET to fetch NT_PRSTATUS and NT_FPREGSET. (authored by jhb). · Explain WhyMar 10 2022, 11:41 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG4965ac059da1: gcore: Use PT_GETREGSET to fetch NT_PRSTATUS and NT_FPREGSET..

jhb added a commit: rG6c2ea7f890b1: gcore: Use PT_GETREGSET to fetch NT_PRSTATUS and NT_FPREGSET..May 12 2022, 10:58 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

gcore/

59 lines

87 lines

Diff 103740

usr.bin/gcore/elf32core.c

Loading...

usr.bin/gcore/elfcore.c

Loading...