bhyve/snapshot: limit snapshot filename to NAME_MAX
ClosedPublic
Actions

Authored by rew on Feb 15 2022, 11:08 PM.

Details

Reviewers

Group Reviewers

Commits

rG4b905478ffe4: bhyve/snapshot: limit snapshot filename to NAME_MAX
rG961e6a12efdb: bhyve/snapshot: limit snapshot filename to NAME_MAX

Summary

NAME_MAX is a better fit since strcat_extension() constructs the
filename of the snapshot file.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44470
Build 41358: arc lint + arc unit

Event Timeline

rew created this revision.Feb 15 2022, 11:08 PM

Herald added a reviewer: bhyve. · View Herald TranscriptFeb 15 2022, 11:08 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

rew requested review of this revision.Feb 15 2022, 11:08 PM

Harbormaster completed remote builds in B44470: Diff 102814.Feb 15 2022, 11:08 PM

rew added a parent revision: D34290: libvmm: use a const char pointer for vm name in struct vmctx.Feb 15 2022, 11:08 PM

rew added a child revision: D34292: bhyve: sweep MAX_VMNAME.

markj accepted this revision as: markj.Feb 28 2022, 2:50 PM

This revision is now accepted and ready to land.Feb 28 2022, 2:50 PM

Closed by commit rG961e6a12efdb: bhyve/snapshot: limit snapshot filename to NAME_MAX (authored by rew). · Explain WhyMar 18 2022, 5:54 AM

This revision was automatically updated to reflect the committed changes.

rew added a commit: rG961e6a12efdb: bhyve/snapshot: limit snapshot filename to NAME_MAX.

jhb added a commit: rG4b905478ffe4: bhyve/snapshot: limit snapshot filename to NAME_MAX.Jan 26 2023, 6:56 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

snapshot.c

6 lines

Diff 102814

View Options

bhyve/snapshot: limit snapshot filename to NAME_MAXClosedPublicActions