vt: implement rotation for framebuffer consoles
Needs ReviewPublic
Actions

Authored by sg2342_googlemail.com on Feb 9 2022, 1:41 AM.

Details

Reviewers

imp
emaste

Summary

tunable "kern.vt.rotate" controls behaviour:
1 - if witdh < height (Portrait mode display): rotate 270 degrees
90 - rotate 90 degrees
180 - rotate 180 degrees
270 - rotate 270 degrees
all other values or undefined - no rotation

https://reviews.freebsd.org/D34220 must be merged before this can go in, otherwise vt_cpulogos will write outside of framebuffer memory if the rotation is 90 or 270.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44367
Build 41255: arc lint + arc unit

Event Timeline

sg2342_googlemail.com created this revision.Feb 9 2022, 1:41 AM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptFeb 9 2022, 1:41 AM

sg2342_googlemail.com requested review of this revision.Feb 9 2022, 1:41 AM

Harbormaster completed remote builds in B44365: Diff 102544.Feb 9 2022, 1:41 AM

sg2342_googlemail.com edited the summary of this revision. (Show Details)Feb 9 2022, 1:51 AM

sg2342_googlemail.com edited the summary of this revision. (Show Details)Feb 9 2022, 2:28 AM

sg2342_googlemail.com added reviewers: imp, emaste.

cem added a subscriber: cem.Feb 9 2022, 2:46 AM

cem added inline comments.

sys/sys/fbio.h
159–160	Maybe 0x10, 0x20?

sg2342_googlemail.com mentioned this in D34220: vt: fix splash_cpu logos use of vd_drawrect.Feb 9 2022, 2:50 AM

sg2342_googlemail.com added inline comments.Feb 9 2022, 2:55 AM

sys/sys/fbio.h
159–160	I am not even sure these belong in fbio.h at all; i'm also unsure about the naming. before this change elements of fb_info where relevant for all fb users, the _ROTATE_ flags are only relevant for vt. but i needed a place to stash 2 bits.