Page MenuHomeFreeBSD

Support vt(4) console screen rotation for panels mounted at non-native orientations.
AcceptedPublic

Authored by crahman_gmail.com on Fri, Jul 29, 6:55 AM.

Details

Reviewers
manu
gbe
pauamma
Group Reviewers
manpages
Summary

Based upon initial work posted by Stefan Grundmann <sg2342@googlemail.com> to
freebsd-hackers and later posted here for review on https://reviews.freebsd.org/D34221,
this is one of three patches adding support for non-native panel orientation to
the vt(4) console

The other two patches add similar support to /boot/loader and to the drm module.

Each of these patches may be applied separately or not, but consistent
rotation through all phases of bootstrapping and running the system console
will require all three.

The screen orientation is set by adding

screen.rotate="angle"

to /boot/loader.conf. The drm-kms driver has independent support for
discovering the correct orientation through BIOS flags (which are, however,
not yet in much use by manufacturers) and through (unimplemented on FreeBSD)
quirk tables. Once KMS is loaded, if it discovers the correct panel orientation,
the screen orientation will be set without the loader.conf setting.

Test Plan

Edit /boot/loader.conf to add the screen.rotate key/value, and reboot.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 46697
Build 43586: arc lint + arc unit

Event Timeline

gbe added a subscriber: gbe.

LGTM for the man page parts.

This revision is now accepted and ready to land.Fri, Jul 29, 2:52 PM
pauamma added a subscriber: pauamma.
pauamma added inline comments.
share/man/man4/vt.4
27

Bump.

363
364
This revision now requires changes to proceed.Sat, Jul 30, 12:59 AM
crahman_gmail.com marked 2 inline comments as done.
  • Modified in response to reviews for D35983.
  • Modified (further) in response to reviews for D35983 (forgot to bump date).
crahman_gmail.com added inline comments.
share/man/man4/vt.4
364

Thanks. I'll also be making a small change to loader.conf.5, below, so please look over it again.

English LGTM. Can't vouch for consistency with source code or correctness of that.

This revision is now accepted and ready to land.Mon, Aug 1, 8:47 AM