This looks correct to me, assuming it builds; I had tried a naive MK_PIE -> target(ubldr.bin) last night and noticed OBJS was problematic, but you've repositioned it and added another target dependency which seems promising.

This revision is now accepted and ready to land.Feb 7 2022, 5:46 PM

Thanks @kevans I was wondering where the MK_PIE came from - I guess just an accidental copy/paste from elsewhere.

In D34189#773560, @emaste wrote:

Thanks @kevans I was wondering where the MK_PIE came from - I guess just an accidental copy/paste from elsewhere.

It seemed like a good idea at the time, but it wasn't. I think it is as @kevans speculated: I mistranslated the powerpc conditionals and didn't notice at the time because almost nothing actually uses this.
I have other patches that remove copying it.

imp added child revisions: D34191: nanobsd: Stop copying ubldr, D34192: release: Don't install ubldr.bin.Feb 7 2022, 5:54 PM

Closed by commit rG27e64c99e4d6: stand/uboot: Fix building of ubldr.bin (authored by imp). · Explain WhyFeb 7 2022, 8:20 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG27e64c99e4d6: stand/uboot: Fix building of ubldr.bin.

imp added a commit: rG8eba35cfe13f: stand/uboot: Fix building of ubldr.bin.Jan 24 2023, 10:13 PM