Page MenuHomeFreeBSD

stand/uboot: Fix building of ubldr.bin
ClosedPublic

Authored by imp on Feb 7 2022, 6:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 8, 2:18 PM
Unknown Object (File)
Mon, Jul 8, 2:12 AM
Unknown Object (File)
Jun 8 2024, 1:23 PM
Unknown Object (File)
Jun 8 2024, 11:58 AM
Unknown Object (File)
May 28 2024, 5:56 PM
Unknown Object (File)
May 28 2024, 5:56 PM
Unknown Object (File)
May 28 2024, 5:55 PM
Unknown Object (File)
May 27 2024, 6:32 AM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44313
Build 41201: arc lint + arc unit

Event Timeline

imp requested review of this revision.Feb 7 2022, 6:19 AM

Do you know where this broke?

This looks correct to me, assuming it builds; I had tried a naive MK_PIE -> target(ubldr.bin) last night and noticed OBJS was problematic, but you've repositioned it and added another target dependency which seems promising.

This revision is now accepted and ready to land.Feb 7 2022, 5:46 PM

Thanks @kevans I was wondering where the MK_PIE came from - I guess just an accidental copy/paste from elsewhere.

Thanks @kevans I was wondering where the MK_PIE came from - I guess just an accidental copy/paste from elsewhere.

It seemed like a good idea at the time, but it wasn't. I think it is as @kevans speculated: I mistranslated the powerpc conditionals and didn't notice at the time because almost nothing actually uses this.
I have other patches that remove copying it.

This revision was automatically updated to reflect the committed changes.