Page MenuHomeFreeBSD

stand/uboot: Fix building of ubldr.bin
ClosedPublic

Authored by imp on Feb 7 2022, 6:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 2, 11:40 AM
Unknown Object (File)
Mon, Sep 30, 4:59 AM
Unknown Object (File)
Fri, Sep 27, 11:21 AM
Unknown Object (File)
Thu, Sep 26, 2:30 AM
Unknown Object (File)
Wed, Sep 25, 5:21 AM
Unknown Object (File)
Tue, Sep 17, 3:11 PM
Unknown Object (File)
Aug 19 2024, 7:09 AM
Unknown Object (File)
Aug 11 2024, 8:48 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Feb 7 2022, 6:19 AM

Do you know where this broke?

This looks correct to me, assuming it builds; I had tried a naive MK_PIE -> target(ubldr.bin) last night and noticed OBJS was problematic, but you've repositioned it and added another target dependency which seems promising.

This revision is now accepted and ready to land.Feb 7 2022, 5:46 PM

Thanks @kevans I was wondering where the MK_PIE came from - I guess just an accidental copy/paste from elsewhere.

Thanks @kevans I was wondering where the MK_PIE came from - I guess just an accidental copy/paste from elsewhere.

It seemed like a good idea at the time, but it wasn't. I think it is as @kevans speculated: I mistranslated the powerpc conditionals and didn't notice at the time because almost nothing actually uses this.
I have other patches that remove copying it.

This revision was automatically updated to reflect the committed changes.