Page MenuHomeFreeBSD
Differential D34170

Stop single stepping in signal handers on arm64
ClosedPublic
Actions

Authored by andrew on Feb 4 2022, 3:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 17, 3:46 PM
Unknown Object (File)
Thu, Oct 17, 12:07 PM
Unknown Object (File)
Wed, Oct 9, 4:46 AM
Unknown Object (File)
Wed, Oct 9, 4:46 AM
Unknown Object (File)
Wed, Oct 9, 4:45 AM
Unknown Object (File)
Wed, Oct 9, 4:45 AM
Unknown Object (File)
Wed, Oct 9, 4:45 AM
Unknown Object (File)
Wed, Oct 9, 4:19 AM
View All 73 Files
Subscribers
emaste
imp

Details

Reviewers
kib
jhb
manu
Group Reviewers
arm64
Commits
rG598e53b3d39c: Stop single stepping in signal handers on arm64
rG31cf95cec738: Stop single stepping in signal handers on arm64
Summary

We should clear the single step flag when entering a signal hander and
set it when returning. This fixes the ptrace__PT_STEP_with_signal test.

While here add support for userspace to set the single step bit as on
x86. This can be used by userspace for self tracing.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44317
Build 41205: arc lint + arc unit

Event Timeline

andrew created this revision.Feb 4 2022, 3:41 PM
Herald added a reviewer: manu. · View Herald TranscriptFeb 4 2022, 3:41 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
andrew requested review of this revision.Feb 4 2022, 3:41 PM
Harbormaster completed remote builds in B44288: Diff 102375.Feb 4 2022, 3:41 PM
andrew added a comment.Feb 4 2022, 3:43 PM

64-bit works. I still need to test the COMPAT32 case.

kib added inline comments.Feb 4 2022, 6:28 PM
tests/sys/kern/basic_signal.c
83

This should be

ucp->uc_mcontext.mc_rflags |= PSL_T;

for amd64, and

ucp->uc_mcontext.mc_eflags |= PSL_T;

for i386.

andrew updated this revision to Diff 102453.Feb 7 2022, 2:02 PM

Add COMPAT32 support

Harbormaster completed remote builds in B44317: Diff 102453.Feb 7 2022, 2:02 PM
andrew updated this revision to Diff 102454.EditedFeb 7 2022, 2:11 PM

Asd untested x86 test support

Harbormaster completed remote builds in B44318: Diff 102454.Feb 7 2022, 2:11 PM
kib accepted this revision.Feb 7 2022, 2:58 PM
This revision is now accepted and ready to land.Feb 7 2022, 2:58 PM
Closed by commit rG31cf95cec738: Stop single stepping in signal handers on arm64 (authored by andrew). · Explain WhyFeb 7 2022, 3:25 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG31cf95cec738: Stop single stepping in signal handers on arm64.
andrew added a commit: rG598e53b3d39c: Stop single stepping in signal handers on arm64.Feb 22 2022, 4:41 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
39 lines
30 lines
12 lines
12 lines
include/
3 lines
tests/
sys/
kern/
57 lines

Diff 102453

View Options

sys/arm64/arm64/exec_machdep.c

Loading...
View Options

sys/arm64/arm64/freebsd32_machdep.c

Loading...
View Options

sys/arm64/arm64/ptrace_machdep.c

Loading...
View Options

sys/arm64/arm64/trap.c

Loading...
View Options

sys/arm64/include/armreg.h

Loading...
View Options

tests/sys/kern/basic_signal.c

Loading...