Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jun 21, 1:55 PM

	Unknown Object (File)
	Thu, Jun 18, 6:01 PM

	Unknown Object (File)
	Wed, Jun 10, 6:15 AM

	Unknown Object (File)
	May 28 2026, 11:40 AM

	Unknown Object (File)
	May 17 2026, 9:22 AM

	Unknown Object (File)
	May 15 2026, 2:25 PM

	Unknown Object (File)
	May 15 2026, 12:16 PM

	Unknown Object (File)
	May 15 2026, 12:31 AM

View All Files

Subscribers

imp

mslehto_kapsi.fi

Details

Reviewers

bapt
kevans

Commits

rG166551aa4da5: dma: use canonical getline() loop
rG2e8403e02158: dma: use canonical getline() loop
rGd21e71efce39: dma: use canonical getline() loop

Summary

getline() returns -1 on erorr or EOF, so just use that condition instead of feof().

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Feb 3 2022, 6:52 PM

emaste created this revision.

add errno check

related upstream discussion in https://github.com/corecode/dma/issues/18

Missing {

I don't know why I went the complicated way in the first place ;)

This revision is now accepted and ready to land.Feb 3 2022, 7:22 PM

kevans accepted this revision.Feb 3 2022, 7:36 PM

explicitly set errno = 0 before loop; getline() leaves it unchanged upon EOF

This revision now requires review to proceed.Feb 4 2022, 5:20 PM

use ferror rather than futzing with errno

This revision was not accepted when it landed; it landed in state Needs Review.Feb 6 2022, 2:56 AM

Closed by commit rGd21e71efce39: dma: use canonical getline() loop (authored by emaste). · Explain Why

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGd21e71efce39: dma: use canonical getline() loop.

Herald added a subscriber: imp. · View Herald TranscriptFeb 6 2022, 2:56 AM

emaste added a commit: rG2e8403e02158: dma: use canonical getline() loop.Sep 26 2022, 2:27 PM

mslehto_kapsi.fi added a subscriber: mslehto_kapsi.fi.Sep 29 2022, 7:51 AM

emaste added a commit: rG166551aa4da5: dma: use canonical getline() loop.Nov 18 2022, 9:00 PM

dma: use canonical getline() loop
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 102419

contrib/dma/mail.c

dma: use canonical getline() loopClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 102419

contrib/dma/mail.c

dma: use canonical getline() loop
ClosedPublic
Actions

Revision Contents
Changeset List