Page MenuHomeFreeBSD
Differential D34159

dma: use canonical getline() loop
ClosedPublic
Actions

Authored by emaste on Feb 3 2022, 6:52 PM.
Tags
None
Referenced Files
F156672827: D34159.id102419.diff
Fri, May 15, 2:25 PM
F156661428: D34159.id102337.diff
Fri, May 15, 12:16 PM
Unknown Object (File)
Fri, May 15, 12:31 AM
Unknown Object (File)
Fri, May 15, 12:30 AM
Unknown Object (File)
Thu, May 14, 10:02 PM
Unknown Object (File)
Thu, May 14, 9:54 PM
Unknown Object (File)
Thu, May 14, 6:26 PM
Unknown Object (File)
Tue, May 12, 3:39 PM
View All Files
Subscribers
imp
mslehto_kapsi.fi

Details

Reviewers
bapt
kevans
Commits
rG166551aa4da5: dma: use canonical getline() loop
rG2e8403e02158: dma: use canonical getline() loop
rGd21e71efce39: dma: use canonical getline() loop
Summary

getline() returns -1 on erorr or EOF, so just use that condition instead of feof().

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.Feb 3 2022, 6:52 PM
emaste created this revision.
emaste updated this revision to Diff 102339.Feb 3 2022, 7:08 PM

add errno check

emaste added a comment.Feb 3 2022, 7:08 PM

related upstream discussion in https://github.com/corecode/dma/issues/18

emaste updated this revision to Diff 102340.Feb 3 2022, 7:09 PM

Missing {

bapt accepted this revision.Feb 3 2022, 7:22 PM

I don't know why I went the complicated way in the first place ;)

This revision is now accepted and ready to land.Feb 3 2022, 7:22 PM
kevans accepted this revision.Feb 3 2022, 7:36 PM
emaste updated this revision to Diff 102378.Feb 4 2022, 5:20 PM

explicitly set errno = 0 before loop; getline() leaves it unchanged upon EOF

This revision now requires review to proceed.Feb 4 2022, 5:20 PM
emaste updated this revision to Diff 102419.Feb 5 2022, 9:52 PM

use ferror rather than futzing with errno

This revision was not accepted when it landed; it landed in state Needs Review.Feb 6 2022, 2:56 AM
Closed by commit rGd21e71efce39: dma: use canonical getline() loop (authored by emaste). · Explain Why
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rGd21e71efce39: dma: use canonical getline() loop.
Herald added a subscriber: imp. · View Herald TranscriptFeb 6 2022, 2:56 AM
emaste added a commit: rG2e8403e02158: dma: use canonical getline() loop.Sep 26 2022, 2:27 PM
mslehto_kapsi.fi added a subscriber: mslehto_kapsi.fi.Sep 29 2022, 7:51 AM
emaste added a commit: rG166551aa4da5: dma: use canonical getline() loop.Nov 18 2022, 9:00 PM

Revision Contents
Changeset List

PathSize
contrib/
dma/
9 lines

Diff 102340

View Options

contrib/dma/mail.c

Loading...