Page MenuHomeFreeBSD

dma: use canonical getline() loop
ClosedPublic

Authored by emaste on Feb 3 2022, 6:52 PM.
Tags
None
Referenced Files
F86941152: D34159.id102419.diff
Thu, Jun 27, 3:22 PM
F86871600: D34159.id.diff
Wed, Jun 26, 8:03 PM
Unknown Object (File)
Tue, Jun 25, 8:08 AM
Unknown Object (File)
Tue, Jun 25, 1:58 AM
Unknown Object (File)
Mon, Jun 24, 3:30 PM
Unknown Object (File)
Mon, Jun 24, 10:18 AM
Unknown Object (File)
Mon, Jun 24, 8:51 AM
Unknown Object (File)
Mon, Jun 24, 8:50 AM

Details

Summary

getline() returns -1 on erorr or EOF, so just use that condition instead of feof().

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.Feb 3 2022, 6:52 PM
emaste created this revision.

I don't know why I went the complicated way in the first place ;)

This revision is now accepted and ready to land.Feb 3 2022, 7:22 PM

explicitly set errno = 0 before loop; getline() leaves it unchanged upon EOF

This revision now requires review to proceed.Feb 4 2022, 5:20 PM

use ferror rather than futzing with errno

This revision was not accepted when it landed; it landed in state Needs Review.Feb 6 2022, 2:56 AM
This revision was automatically updated to reflect the committed changes.