Page MenuHomeFreeBSD
Differential D34128

filemon: Reject FILEMON_SET_FD commands when the fd is a kqueue
ClosedPublic
Actions

Authored by markj on Feb 1 2022, 2:59 PM.
Tags
None
Referenced Files
F103325542: D34128.id102237.diff
Sat, Nov 23, 2:11 PM
F103318528: D34128.id102237.diff
Sat, Nov 23, 11:58 AM
Unknown Object (File)
Sat, Nov 23, 2:59 AM
Unknown Object (File)
Fri, Nov 22, 11:01 PM
Unknown Object (File)
Thu, Nov 21, 11:21 PM
Unknown Object (File)
Wed, Nov 13, 6:55 AM
Unknown Object (File)
Thu, Oct 31, 6:28 AM
Unknown Object (File)
Mon, Oct 28, 4:01 PM
View All 67 Files
Subscribers
debdrup
emaste
imp
pauamma_gundo.com

Details

Reviewers
bdrewery
debdrup
emaste
Group Reviewers
manpages
Commits
rG03399cd6e04e: filemon.4: Document FILEMON_SET_FD errors and refine wording a bit
rGb84ed4e7f626: filemon: Reject FILEMON_SET_FD commands when the fd is a kqueue
Summary

When FILEMON_SET_FD is used, the filemon handle effectively wraps the
passed file. In particular, the handle may be inherited by a child
process, or transferred over a unix domain socket, so we must verify
that the backing file permits this.

Reported by: syzbot+36e6be9e02735fe66ca8@syzkaller.appspotmail.com

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44225
Build 41113: arc lint + arc unit

Event Timeline

markj created this revision.Feb 1 2022, 2:59 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 1 2022, 2:59 PM
markj requested review of this revision.Feb 1 2022, 2:59 PM
Harbormaster completed remote builds in B44220: Diff 102215.Feb 1 2022, 2:59 PM
emaste added a subscriber: emaste.Feb 1 2022, 5:01 PM

Looks reasonable. filemon.4 needs an update too?

markj updated this revision to Diff 102220.Feb 1 2022, 5:30 PM

Document EINVAL and EBADF.

Herald added a reviewer: manpages. · View Herald TranscriptFeb 1 2022, 5:30 PM
Harbormaster completed remote builds in B44225: Diff 102220.Feb 1 2022, 5:30 PM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.Feb 1 2022, 6:12 PM

Besides that unrelated nit, the manual page language LGTM. Can't speak to consistency with the code change.

share/man/man4/filemon.4
54–55

"binaries using an emulated ABI" maybe? Neither "of" and "foreign" look quite right.

markj updated this revision to Diff 102237.Feb 1 2022, 10:03 PM
markj marked an inline comment as done.

Unrelated fixups. Change "will" to "may" since filemon does at least
hook compat32 system calls.

Harbormaster completed remote builds in B44235: Diff 102237.Feb 1 2022, 10:04 PM
debdrup accepted this revision.Feb 2 2022, 8:01 AM
debdrup added a subscriber: debdrup.

Manual page changes look good to me, can't comment on the code.

This revision is now accepted and ready to land.Feb 2 2022, 8:01 AM
emaste accepted this revision.Feb 2 2022, 6:19 PM
emaste added inline comments.
share/man/man4/filemon.4
54–55

"emulated" isn't quite right

Possibly "non-native" or "non-FreeBSD" ABIs

54–55

Oops this comment was stuck as a draft

pauamma_gundo.com added a comment.Feb 3 2022, 3:20 AM

LGTM too.

Closed by commit rGb84ed4e7f626: filemon: Reject FILEMON_SET_FD commands when the fd is a kqueue (authored by markj). · Explain WhyFeb 3 2022, 2:47 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGb84ed4e7f626: filemon: Reject FILEMON_SET_FD commands when the fd is a kqueue.
markj added a commit: rG03399cd6e04e: filemon.4: Document FILEMON_SET_FD errors and refine wording a bit.
bdrewery added a comment.Feb 8 2022, 11:55 PM

+1

Revision Contents
Changeset List

PathSize
share/
man/
man4/
7 lines
sys/
dev/
filemon/
20 lines

Diff 102220

View Options

share/man/man4/filemon.4

Loading...
View Options

sys/dev/filemon/filemon.c

Loading...