rP383570 likely forgot to run grep(1) over Mk/*. For completeness sake I've converted everything else as well.
Details
Details
- Reviewers
- None
- Group Reviewers
portmgr Perl - Commits
- rP413184: Consistently prefer ${CONFIGURE_CMD} over ./${CONFIGURE_SCRIPT}
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 1138 Build 1142: arc lint + arc unit
Event Timeline
Comment Actions
SET_LATE_CONFIGURE_ARGS is used to pass things like --mandir for GNU_CONFIGURE=yes ports but currently doesn't work with CONFIGURE_CMD (unlike CONFIGURE_SCRIPT). D4157 exposes the bug upon more consumers. Notably, lang/gcc will break without this change:
$ make check-plist ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: share/info/cpp.info Error: Orphaned: share/info/cppinternals.info Error: Orphaned: share/info/gcc.info Error: Orphaned: share/info/gccinstall.info Error: Orphaned: share/info/gccint.info Error: Orphaned: share/info/gfortran.info Error: Orphaned: share/info/libgomp.info Error: Orphaned: share/info/libitm.info Error: Orphaned: share/info/libquadmath.info Error: Orphaned: share/man/man1/cpp48.1 Error: Orphaned: share/man/man1/g++48.1 Error: Orphaned: share/man/man1/gcc48.1 Error: Orphaned: share/man/man1/gcov48.1 Error: Orphaned: share/man/man1/gfortran48.1 Error: Orphaned: share/man/man7/fsf-funding.7 Error: Orphaned: share/man/man7/gfdl.7 Error: Orphaned: share/man/man7/gpl.7 ===> Checking for items in pkg-plist which are not in STAGEDIR Error: Missing: man/man1/cpp48.1.gz Error: Missing: man/man1/g++48.1.gz Error: Missing: man/man1/gcc48.1.gz Error: Missing: man/man1/gcov48.1.gz Error: Missing: man/man1/gfortran48.1.gz ===> Error: Plist issues found.
Are you giving a weak approval to be rubberstamped after exp-run?