Page MenuHomeFreeBSD

libpfctl: fix creatorid endianness
ClosedPublic

Authored by kp on Jan 21 2022, 5:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 15, 12:26 AM
Unknown Object (File)
Thu, Aug 14, 12:39 PM
Unknown Object (File)
Sat, Aug 2, 5:37 AM
Unknown Object (File)
Sun, Jul 27, 1:39 AM
Unknown Object (File)
Sun, Jul 27, 1:12 AM
Unknown Object (File)
Sat, Jul 26, 12:35 PM
Unknown Object (File)
Sat, Jul 26, 8:06 AM
Unknown Object (File)
Fri, Jul 25, 4:00 PM

Details

Summary

We provide the hostid (which is the state creatorid) to the kernel as a
big endian number (see pfctl/pfctl.c pfctl_set_hostid()), so convert it
back to system endianness when we get it from the kernel.

This avoids a confusing mismatch between the value the user configures
and the value displayed in the state.

MFC after: 3 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44033
Build 40921: arc lint + arc unit