Page MenuHomeFreeBSD

libpfctl: fix creatorid endianness
ClosedPublic

Authored by kp on Jan 21 2022, 5:36 PM.
Tags
None
Referenced Files
F143497936: D33989.diff
Fri, Jan 30, 6:34 PM
Unknown Object (File)
Wed, Jan 28, 5:38 PM
Unknown Object (File)
Fri, Jan 23, 7:37 AM
Unknown Object (File)
Dec 1 2025, 5:47 PM
Unknown Object (File)
Nov 29 2025, 4:30 PM
Unknown Object (File)
Nov 29 2025, 3:15 AM
Unknown Object (File)
Nov 28 2025, 12:17 PM
Unknown Object (File)
Nov 27 2025, 7:59 AM

Details

Summary

We provide the hostid (which is the state creatorid) to the kernel as a
big endian number (see pfctl/pfctl.c pfctl_set_hostid()), so convert it
back to system endianness when we get it from the kernel.

This avoids a confusing mismatch between the value the user configures
and the value displayed in the state.

MFC after: 3 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44033
Build 40921: arc lint + arc unit