Differential D33804

Remove the arm FIQ support
ClosedPublic
Actions

Authored by andrew on Jan 10 2022, 2:17 PM.

Tags

None

Referenced Files

	F169410068: D33804.diff
	Tue, Sep 1, 11:31 AM

	F169360276: D33804.id101198.diff
	Tue, Sep 1, 7:50 AM

	F169235279: D33804.id.diff
	Tue, Sep 1, 12:10 AM

	Unknown Object (File)
	Sun, Aug 30, 11:53 AM

	Unknown Object (File)
	Sun, Aug 30, 12:00 AM

	Unknown Object (File)
	Sat, Aug 29, 4:04 PM

	Unknown Object (File)
	Wed, Aug 26, 9:13 PM

	Unknown Object (File)
	Wed, Aug 26, 9:09 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG6abad5b6062d: Remove the arm FIQ support

Summary

It isn't used, and only masks/unmasks FIQs on the local CPU so will be
broken on SMP.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43802
Build 40690: arc lint + arc unit

Event Timeline

andrew created this revision.Jan 10 2022, 2:17 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 10 2022, 2:17 PM

andrew requested review of this revision.Jan 10 2022, 2:17 PM

Harbormaster completed remote builds in B43802: Diff 101195.Jan 10 2022, 2:17 PM

Remove more fiq bits

Harbormaster completed remote builds in B43803: Diff 101198.Jan 10 2022, 2:43 PM

mmel added a subscriber: mmel.Jan 10 2022, 2:49 PM

mmel added inline comments.

sys/arm/arm/exception.S
385	.fiqv should be also removed
386	and also this .space and _C_LABEL(page0_data) on the next line. In addition, the arm_vector_init() function in machdep.c should be modified accordingly.

Remove more FIQ support

Harbormaster completed remote builds in B58066: Diff 139511.Jun 5 2024, 2:34 PM

mmel accepted this revision.Jun 9 2024, 3:29 PM

This revision is now accepted and ready to land.Jun 9 2024, 3:29 PM

Closed by commit rG6abad5b6062d: Remove the arm FIQ support (authored by andrew). · Explain WhyJun 10 2024, 3:30 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG6abad5b6062d: Remove the arm FIQ support.

Revision Contents
Changeset List

Path

Size

sys/

arm/

arm/

13 lines

include/

Diff 101195

sys/arm/arm/exception.S

Loading...

sys/arm/arm/fiq.c

Loading...

sys/arm/arm/fiq_subr.S

Loading...

sys/arm/include/fiq.h

Loading...