Convert bsdinstall/distextract for libbsddialog
ClosedPublic
Actions

Authored by asiciliano on Dec 20 2021, 2:46 AM.

Details

Reviewers

bapt
nwhitehorn
dteske
emaste

Commits

rG18f20d5d967a: bsddialog: convert bsdinstall/distextract

Summary

Convert bsdinstall/distextract for libbsddialog.

This review depends on libbsddialog 0.0.2 https://reviews.freebsd.org/D33580

Test Plan

Download some txz from distfetch https://reviews.freebsd.org/D33425
then:

env DISTRIBUTIONS="kernel.txz tests.txz" BSDINSTALL_CHROOT="./extractdir" BSDINSTALL_DISTDIR="/home/test" ./distextract
`

┌────────Archive Extraction────────┐                      
│ kernel.txz       [    Done     ] │                      
│ tests.txz        [    Done     ] │                      
│                                  │                      
│ Extracting distribution files... │                      
│                                  │                      
│  ┌─Overall Progress───────────┐  │                      
│  │            100%            │  │                      
│  └────────────────────────────┘  │                      
└──────────────────────────────────┘

`
ls extractdir/boot/kernel/
... kmods and company ...

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

asiciliano created this revision.Dec 20 2021, 2:46 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 20 2021, 2:46 AM

asiciliano requested review of this revision.Dec 20 2021, 2:46 AM

bapt accepted this revision.Dec 21 2021, 3:14 PM

This revision is now accepted and ready to land.Dec 21 2021, 3:14 PM

bapt added inline comments.Dec 21 2021, 3:15 PM

usr.sbin/bsdinstall/distextract/Makefile
5–6	HAVE_BSDDIALOG is not necessary here, why adding it?

asiciliano added inline comments.Dec 21 2021, 4:26 PM

usr.sbin/bsdinstall/distextract/Makefile
5–6	Ops sorry, of course it is an error (I opened the tzseup Makefile instead of the distfetch Makefile). Should I update the review or can you fix before to commit?