Page MenuHomeFreeBSD
Differential D33543

inpcb: garbage collect INP_LOCK_INIT(), used only once in sctp
ClosedPublic
Actions

Authored by glebius on Dec 17 2021, 7:03 PM.
Tags
None
Referenced Files
F153218545: D33543.id.diff
Sun, Apr 19, 9:17 PM
Unknown Object (File)
Sat, Apr 18, 2:17 AM
Unknown Object (File)
Wed, Apr 15, 9:08 PM
Unknown Object (File)
Wed, Apr 15, 2:20 PM
Unknown Object (File)
Wed, Apr 15, 2:10 PM
Unknown Object (File)
Wed, Apr 15, 7:07 AM
Unknown Object (File)
Sun, Apr 5, 12:29 PM
Unknown Object (File)
Sat, Apr 4, 1:56 AM
View All Files
Subscribers
imp
melifaro
tuexen

Details

Reviewers
tuexen
Group Reviewers
network
transport
Commits
rGafad340a14f8: inpcb: garbage collect INP_LOCK_INIT(), used only once in sctp

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43449
Build 40337: arc lint + arc unit

Event Timeline

glebius created this revision.Dec 17 2021, 7:03 PM
Herald added a reviewer: transport. · View Herald TranscriptDec 17 2021, 7:03 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
glebius requested review of this revision.Dec 17 2021, 7:03 PM
glebius added a parent revision: D33542: inpcb: use global UMA zones for protocols.
Harbormaster completed remote builds in B43449: Diff 100230.Dec 17 2021, 7:03 PM
tuexen added a subscriber: tuexen.Dec 17 2021, 7:53 PM
tuexen added inline comments.
sys/netinet/sctp_pcb.c
2501

Could you just replace the code here instead of putting it into SCTP_INP_LOCK_INIT()?

glebius updated this revision to Diff 100231.Dec 17 2021, 8:10 PM

Re-do per Michael suggestion.

Harbormaster completed remote builds in B43450: Diff 100231.Dec 17 2021, 8:10 PM
glebius marked an inline comment as done.Dec 17 2021, 8:10 PM
tuexen accepted this revision.Dec 17 2021, 8:15 PM
This revision is now accepted and ready to land.Dec 17 2021, 8:15 PM
Closed by commit rGafad340a14f8: inpcb: garbage collect INP_LOCK_INIT(), used only once in sctp (authored by glebius). · Explain WhyJan 3 2022, 6:23 PM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rGafad340a14f8: inpcb: garbage collect INP_LOCK_INIT(), used only once in sctp.

Revision Contents
Changeset List

PathSize
sys/
netinet/
2 lines
2 lines
1 line

Diff 100230

View Options

sys/netinet/in_pcb.h

Loading...
View Options

sys/netinet/sctp_lock_bsd.h

Loading...
View Options

sys/netinet/sctp_pcb.c

Loading...