net: make ethernet.h self-contained
ClosedPublic
Actions

Authored by kp on Dec 16 2021, 9:30 AM.

Details

Reviewers

Group Reviewers

network
pfsense

Commits

rGf4096a7c8a5b: net: make ethernet.h self-contained

Summary

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43408
Build 40296: arc lint + arc unit

Event Timeline

kp created this revision.Dec 16 2021, 9:30 AM

Herald added subscribers: glebius, melifaro, ae. · View Herald TranscriptDec 16 2021, 9:30 AM

kp requested review of this revision.Dec 16 2021, 9:30 AM

Harbormaster completed remote builds in B43408: Diff 100129.Dec 16 2021, 9:30 AM

kp added a parent revision: D33500: sys: make callout.h self-contained.Dec 16 2021, 9:30 AM

kp added a child revision: D33502: net: make if_bridgevar.h self-contained.

imp accepted this revision.Dec 16 2021, 9:33 AM

This revision is now accepted and ready to land.Dec 16 2021, 9:33 AM

Could you by any chance add the rationale to the diff description?

In D33501#757387, @melifaro wrote:

Could you by any chance add the rationale to the diff description?

The point is to ensure that users (both in the kernel and in user space) can include this header without having to know they're supposed to include <sys/types.h> first.
There's a whole series of these, because we have a lot of headers where that doesn't work (and worse cases that just this), and it's often frustrating to go hunting for the required includes.

Closed by commit rGf4096a7c8a5b: net: make ethernet.h self-contained (authored by kp). · Explain WhyDec 17 2021, 11:39 AM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGf4096a7c8a5b: net: make ethernet.h self-contained.