Page MenuHomeFreeBSD

net: make ethernet.h self-contained
ClosedPublic

Authored by kp on Dec 16 2021, 9:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 7 2024, 12:27 PM
Unknown Object (File)
Oct 19 2024, 12:59 PM
Unknown Object (File)
Oct 18 2024, 1:31 AM
Unknown Object (File)
Oct 1 2024, 1:00 PM
Unknown Object (File)
Sep 30 2024, 9:29 PM
Unknown Object (File)
Sep 24 2024, 4:15 AM
Unknown Object (File)
Sep 23 2024, 11:16 AM
Unknown Object (File)
Sep 17 2024, 4:41 PM

Details

Summary

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp requested review of this revision.Dec 16 2021, 9:30 AM
This revision is now accepted and ready to land.Dec 16 2021, 9:33 AM

Could you by any chance add the rationale to the diff description?

Could you by any chance add the rationale to the diff description?

The point is to ensure that users (both in the kernel and in user space) can include this header without having to know they're supposed to include <sys/types.h> first.
There's a whole series of these, because we have a lot of headers where that doesn't work (and worse cases that just this), and it's often frustrating to go hunting for the required includes.

This revision was automatically updated to reflect the committed changes.