Publish fp[get][set]sticky() for ARMv6.
ClosedPublic
Actions

Authored by mmel on Feb 16 2017, 1:12 PM.

Details

Reviewers

kib
dim

Commits

rS313873: Publish fp[get][set]sticky() for ARMv6.

Summary

Although fp[get][set]sticky() functions are obsolete, they are still
required for GNU fortran49 library.

MFC after: 2 months

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mmel updated this revision to Diff 25269.Feb 16 2017, 1:12 PM

mmel retitled this revision from to Publish fp[get][set]sticky() for ARMv6..

mmel updated this object.

mmel edited the test plan for this revision. (Show Details)

mmel added reviewers: kib, dim.

mmel set the repository for this revision to rS FreeBSD src repository - subversion.

mmel added a subscriber: ARM.

Herald added subscribers: andrew, imp. · View Herald TranscriptFeb 16 2017, 1:12 PM

Should the symbols go into FBSD_1.5 namespace instead ? Are they added anew for CURRENT-12, or they were already exported and then (erronously) removed from the version file ?

Hard to say.
I take this as fix for r264721 where group of fp* functions was been added, but only some are exported.
These functions are not a new, we just lacked their publishing.

In any case, I have no problem to put this to FBSD_1.5 if you prefer this way.

In D9634#199286, @meloun-miracle-cz wrote:

Hard to say.
I take this as fix for r264721 where group of fp* functions was been added, but only some are exported.
These functions are not a new, we just lacked their publishing.

In any case, I have no problem to put this to FBSD_1.5 if you prefer this way.

I do not see any export done in r264721. Anyway, by formal rules symbols should go into FBSD_1.5, but 1.0 would be fine as well, for several reasons.

Export symbols within FBSD_1.5 namespace.

kib accepted this revision.Feb 17 2017, 1:25 PM

kib edited edge metadata.

This revision is now accepted and ready to land.Feb 17 2017, 1:25 PM

Closed by commit rS313873: Publish fp[get][set]sticky() for ARMv6. (authored by mmel). · Explain WhyFeb 17 2017, 1:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

lib/

libc/

arm/

Symbol_vfp.map

5 lines

Diff 25315

View Options

head/lib/libc/arm/Symbol_vfp.map

Publish fp[get][set]sticky() for ARMv6.ClosedPublicActions