Page MenuHomeFreeBSD

snd_hda(4): reserve one more sequence number (14) for headphones redirection
AcceptedPublic

Authored by avos on Feb 12 2017, 7:14 PM.

Details

Reviewers
mav
mmel
bcr
Group Reviewers
manpages
Summary

This will allow to handle one more additional output (one on the laptop + another one on the docking station in my case) for automatic speaker <-> headphones switch.

P.S. Probably, automatic association change (e.g., when all devices were disconnected) would be better here...

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

avos retitled this revision from to snd_hda(4): reserve one more sequence number (14) for headphones redirection.
avos updated this object.
avos edited the test plan for this revision. (Show Details)
avos added reviewers: mmel, mav.
avos set the repository for this revision to rS FreeBSD src repository - subversion.

Small grammar fix for the man page.

share/man/man4/snd_hda.4
230–231

s/has/have/

avos edited edge metadata.

s/has/have (twice)

avos marked an inline comment as done.Feb 12 2017, 7:37 PM
bcr added a reviewer: bcr.

OK from the doc side of things.

This revision is now accepted and ready to land.Feb 12 2017, 7:50 PM
wblock added inline comments.
share/man/man4/snd_hda.4
233

Remove "will" and reorder to remove the confusing aside (ignoring wrap, phabricator makes it hard to see where that needs to be):

duplicate the first pin in that assocation and provide automatic mute if jack detection is supported.
237

s/in/in an/

238

This sentence is hard to understand. Does "none of them" mean assocations or sequence numbers?

The last part is also unclear. Should it say "and there *is* more than one pin in *an* association"?

241

s/associations/associations,/

242

s/pairs/pair/