Page MenuHomeFreeBSD
Differential D9261

Switch ports to use USE_PYQT=<foo> instead of ugly BUILD/RUN_DEPENDS
ClosedPublic
Actions

Authored by tcberner on Jan 20 2017, 5:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 28, 7:48 PM
Unknown Object (File)
Mar 6 2024, 11:40 AM
Unknown Object (File)
Mar 4 2024, 4:01 AM
Unknown Object (File)
Mar 4 2024, 4:01 AM
Unknown Object (File)
Mar 4 2024, 4:01 AM
Unknown Object (File)
Mar 4 2024, 4:01 AM
Unknown Object (File)
Mar 4 2024, 4:01 AM
Unknown Object (File)
Mar 3 2024, 1:05 AM
View All 65 Files
Subscribers
None

Details

Reviewers
adridg
rakuco
mat
Group Reviewers
kde
Commits
rP433310: Switch ports to use USE_PYQT=<foo> instead of using RUN_- and BUILD_DEPENDS
Summary

pyqt.mk provides USE_PYQT=<list> to depend on its components. Convert the ports
not yet using it to it.

Test Plan
  • Test build the ports.
  • fixup comms/gnuradio (it depended on the whole shebang, which seems a bit lot at first glance)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tcberner updated this revision to Diff 24241.Jan 20 2017, 5:25 PM
tcberner retitled this revision from to Switch ports to use USE_PYQT=<foo> instead of ugly BUILD/RUN_DEPENDS.
tcberner updated this object.
tcberner edited the test plan for this revision. (Show Details)
tcberner added reviewers: kde, rakuco, mat, adridg.
tcberner added a comment.Jan 21 2017, 11:53 AM

everything seems to still build fine on current.

rakuco accepted this revision.Jan 21 2017, 1:46 PM
rakuco edited edge metadata.

lgtm!

This revision is now accepted and ready to land.Jan 21 2017, 1:46 PM
mat edited edge metadata.Feb 3 2017, 4:39 PM

All the USE_PYQT should be after the USES lines.

www/linkchecker/Makefile
41 ↗(On Diff #24241)

This is going to end up being:

USE_CORE_RUN="" USE_GUI_RUN=""

I think this (and maybe others are wrong.)

mat requested changes to this revision.Feb 3 2017, 4:41 PM
mat edited edge metadata.
This revision now requires changes to proceed.Feb 3 2017, 4:41 PM
tcberner updated this revision to Diff 24694.Feb 3 2017, 6:23 PM
tcberner edited edge metadata.

Fix horribly wrong option in www/linchecker.

tcberner marked an inline comment as done.Feb 3 2017, 6:24 PM
tcberner added inline comments.
www/linkchecker/Makefile
41 ↗(On Diff #24241)

yikes

fixed now

%  make -VUSE_PYQT -C www/linkchecker/
core_run gui_run help_run qscintilla2_run sql_run
tcberner updated this revision to Diff 24695.Feb 3 2017, 6:30 PM
tcberner marked an inline comment as done.
tcberner edited edge metadata.
  • Shuffle USES upwards
  • Remove a typo
mat accepted this revision.Feb 3 2017, 7:53 PM
mat edited edge metadata.

Looks ok.

This revision is now accepted and ready to land.Feb 3 2017, 7:53 PM
Closed by commit rP433310: Switch ports to use USE_PYQT=<foo> instead of using RUN_- and BUILD_DEPENDS (authored by tcberner). · Explain WhyFeb 4 2017, 1:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
comms/
gnuradio/
4 lines
devel/
hgview/
5 lines
ninja-ide/
9 lines
qbzr/
4 lines
qct/
6 lines
tortoisehg/
14 lines
editors/
leo/
7 lines
finance/
bitcoin-armory/
7 lines
electrum/
4 lines
games/
anki/
5 lines
py-mnemosyne/
9 lines
graphics/
py-poppler-qt4/
8 lines
qgis/
21 lines
math/
py-matplotlib/
8 lines
multimedia/
py-openlp/
14 lines
net-p2p/
bitmessage/
6 lines
print/
hplip/
4 lines
science/
ncs/
6 lines
veusz/
7 lines
security/
py-yara-editor/
7 lines
www/
linkchecker/
8 lines

Diff 24717

View Options

head/comms/gnuradio/Makefile

Loading...
View Options

head/devel/hgview/Makefile

Loading...
View Options

head/devel/ninja-ide/Makefile

Loading...
View Options

head/devel/qbzr/Makefile

Loading...
View Options

head/devel/qct/Makefile

Loading...
View Options

head/devel/tortoisehg/Makefile

Loading...
View Options

head/editors/leo/Makefile

Loading...
View Options

head/finance/bitcoin-armory/Makefile

Loading...
View Options

head/finance/electrum/Makefile

Loading...
View Options

head/games/anki/Makefile

Loading...
View Options

head/games/py-mnemosyne/Makefile

Loading...
View Options

head/graphics/py-poppler-qt4/Makefile

Loading...
View Options

head/graphics/qgis/Makefile

Loading...
View Options

head/math/py-matplotlib/Makefile

Loading...
View Options

head/multimedia/py-openlp/Makefile

Loading...
View Options

head/net-p2p/bitmessage/Makefile

Loading...
View Options

head/print/hplip/Makefile

Loading...
View Options

head/science/ncs/Makefile

Loading...
View Options

head/science/veusz/Makefile

Loading...
View Options

head/security/py-yara-editor/Makefile

Loading...
View Options

head/www/linkchecker/Makefile

Loading...