Page MenuHomeFreeBSD
Differential D9261

Switch ports to use USE_PYQT=<foo> instead of ugly BUILD/RUN_DEPENDS
ClosedPublic
Actions

Authored by tcberner on Jan 20 2017, 5:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 7:04 AM
Unknown Object (File)
Sun, Dec 15, 3:03 AM
Unknown Object (File)
Oct 27 2024, 10:59 PM
Unknown Object (File)
Oct 20 2024, 1:51 PM
Unknown Object (File)
Oct 20 2024, 12:22 AM
Unknown Object (File)
Oct 18 2024, 8:45 PM
Unknown Object (File)
Oct 14 2024, 6:28 AM
Unknown Object (File)
Oct 5 2024, 11:47 PM
View All Files
Subscribers
None

Details

Reviewers
adridg
rakuco
mat
Group Reviewers
kde
Commits
rP433310: Switch ports to use USE_PYQT=<foo> instead of using RUN_- and BUILD_DEPENDS
Summary

pyqt.mk provides USE_PYQT=<list> to depend on its components. Convert the ports
not yet using it to it.

Test Plan
  • Test build the ports.
  • fixup comms/gnuradio (it depended on the whole shebang, which seems a bit lot at first glance)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 7164
Build 7334: arc lint + arc unit

Event Timeline

tcberner updated this revision to Diff 24241.Jan 20 2017, 5:25 PM
tcberner retitled this revision from to Switch ports to use USE_PYQT=<foo> instead of ugly BUILD/RUN_DEPENDS.
tcberner updated this object.
tcberner edited the test plan for this revision. (Show Details)
tcberner added reviewers: kde, rakuco, mat, adridg.
tcberner added a comment.Jan 21 2017, 11:53 AM

everything seems to still build fine on current.

rakuco accepted this revision.Jan 21 2017, 1:46 PM
rakuco edited edge metadata.

lgtm!

This revision is now accepted and ready to land.Jan 21 2017, 1:46 PM
mat edited edge metadata.Feb 3 2017, 4:39 PM

All the USE_PYQT should be after the USES lines.

www/linkchecker/Makefile
41

This is going to end up being:

USE_CORE_RUN="" USE_GUI_RUN=""

I think this (and maybe others are wrong.)

mat requested changes to this revision.Feb 3 2017, 4:41 PM
mat edited edge metadata.
This revision now requires changes to proceed.Feb 3 2017, 4:41 PM
tcberner updated this revision to Diff 24694.Feb 3 2017, 6:23 PM
tcberner edited edge metadata.

Fix horribly wrong option in www/linchecker.

tcberner marked an inline comment as done.Feb 3 2017, 6:24 PM
tcberner added inline comments.
www/linkchecker/Makefile
41

yikes

fixed now

%  make -VUSE_PYQT -C www/linkchecker/
core_run gui_run help_run qscintilla2_run sql_run
tcberner updated this revision to Diff 24695.Feb 3 2017, 6:30 PM
tcberner marked an inline comment as done.
tcberner edited edge metadata.
  • Shuffle USES upwards
  • Remove a typo
mat accepted this revision.Feb 3 2017, 7:53 PM
mat edited edge metadata.

Looks ok.

This revision is now accepted and ready to land.Feb 3 2017, 7:53 PM
Closed by commit rP433310: Switch ports to use USE_PYQT=<foo> instead of using RUN_- and BUILD_DEPENDS (authored by tcberner). · Explain WhyFeb 4 2017, 1:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
comms/
gnuradio/
4 lines
devel/
hgview/
5 lines
ninja-ide/
9 lines
qbzr/
4 lines
qct/
6 lines
tortoisehg/
14 lines
editors/
leo/
7 lines
finance/
bitcoin-armory/
7 lines
electrum/
4 lines
games/
anki/
5 lines
py-mnemosyne/
9 lines
graphics/
py-poppler-qt4/
8 lines
qgis/
21 lines
math/
py-matplotlib/
8 lines
multimedia/
py-openlp/
14 lines
net-p2p/
bitmessage/
6 lines
print/
hplip/
4 lines
science/
ncs/
6 lines
veusz/
7 lines
security/
py-yara-editor/
7 lines
www/
linkchecker/
8 lines

Diff 24695

View Options

comms/gnuradio/Makefile

Loading...
View Options

devel/hgview/Makefile

Loading...
View Options

devel/ninja-ide/Makefile

Loading...
View Options

devel/qbzr/Makefile

Loading...
View Options

devel/qct/Makefile

Loading...
View Options

devel/tortoisehg/Makefile

Loading...
View Options

editors/leo/Makefile

Loading...
View Options

finance/bitcoin-armory/Makefile

Loading...
View Options

finance/electrum/Makefile

Loading...
View Options

games/anki/Makefile

Loading...
View Options

games/py-mnemosyne/Makefile

Loading...
View Options

graphics/py-poppler-qt4/Makefile

Loading...
View Options

graphics/qgis/Makefile

Loading...
View Options

math/py-matplotlib/Makefile

Loading...
View Options

multimedia/py-openlp/Makefile

Loading...
View Options

net-p2p/bitmessage/Makefile

Loading...
View Options

print/hplip/Makefile

Loading...
View Options

science/ncs/Makefile

Loading...
View Options

science/veusz/Makefile

Loading...
View Options

security/py-yara-editor/Makefile

Loading...
View Options

www/linkchecker/Makefile

Loading...