Page MenuHomeFreeBSD
Differential D9247

Use SoC ID - based detection in CESA
ClosedPublic
Actions

Authored by mw_semihalf.com on Jan 19 2017, 5:54 PM.
Tags
None
Referenced Files
F136811368: D9247.id24418.diff
Wed, Nov 19, 6:05 PM
F136737392: D9247.id.diff
Wed, Nov 19, 4:11 AM
Unknown Object (File)
Tue, Nov 18, 10:47 PM
Unknown Object (File)
Tue, Nov 18, 4:35 PM
Unknown Object (File)
Tue, Nov 18, 3:23 PM
Unknown Object (File)
Tue, Nov 18, 4:45 AM
Unknown Object (File)
Mon, Nov 17, 3:31 AM
Unknown Object (File)
Fri, Nov 14, 10:45 PM
View All Files
Subscribers
mmel
ARM

Details

Reviewers
zbb
fabient
imp
• ian
Commits
rS312743: Use SoC ID - based detection in CESA
Summary

This commit introduces following changes in order to get rid of
ifdef's from all around the driver.

  • Introduce sc_soc_id field in cesa_softc structure - this value is obtained in cesa_attach() anyway, so make use of it.
  • Replace ifdefs with SoC ID checks.
  • Perform PM control status only for relevant SoC's.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mw_semihalf.com updated this revision to Diff 24204.Jan 19 2017, 5:54 PM
mw_semihalf.com retitled this revision from to Use SoC ID - based detection in CESA.
mw_semihalf.com updated this object.
mw_semihalf.com edited the test plan for this revision. (Show Details)
mw_semihalf.com added a child revision: D9215: Fix SHA256 usage on older CESA versions.
mw_semihalf.com added reviewers: • ian, imp, zbb, fabient.
mw_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.
mw_semihalf.com added subscribers: ARM, mmel.
mw_semihalf.com added a parent revision: D9248: Add misssing Armada38x ID's in CESA attach.Jan 19 2017, 5:57 PM
zbb accepted this revision.Jan 19 2017, 6:09 PM
zbb edited edge metadata.
zbb added inline comments.
sys/dev/cesa/cesa.c
1204

Found it! Style ;-)

This revision is now accepted and ready to land.Jan 19 2017, 6:09 PM
mw_semihalf.com updated this revision to Diff 24230.Jan 20 2017, 12:33 PM
mw_semihalf.com edited edge metadata.

Fix style in one of assignments.

This revision now requires review to proceed.Jan 20 2017, 12:33 PM
Closed by commit rS312743: Use SoC ID - based detection in CESA (authored by wma). · Explain WhyJan 25 2017, 10:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
cesa/
1 line
81 lines

Diff 24204

View Options

sys/dev/cesa/cesa.h

Loading...
View Options

sys/dev/cesa/cesa.c

Loading...