hwpmc module log with full path

[fabient]

Summary

Discuss about a possible solution to find the right kernel module for hwpmc.
Related to D8234.

[jhb]

sys/kern/link_elf_obj.c

561

This probably belongs in the caller (note that non-amd64 use link_elf.c to load
modules)

[fabient]

sys/kern/link_elf_obj.c

561

Do you mean it is better to resolve filename at upper level even if we need to open file again ?

[jhb]

sys/kern/link_elf_obj.c

561

So do you have a use case where the filename isn't already the full path? linker_load_module() in kern_linker.c already passes the pathname (not the basename) to this function.

[fabient]

Le 27 janv. 2017 à 20:05, jhb (John Baldwin) <[e-mail]> a écrit :

jhb added inline comments.

INLINE COMMENTS

fabient wrote in link_elf_obj.c:561
Do you mean it is better to resolve filename at upper level even if we need to open file again ?

So do you have a use case where the filename isn't already the full path? linker_load_module() in kern_linker.c already passes the pathname (not the basename) to this function.

Only relative pathname: custom load script, command line.

REPOSITORY
rS FreeBSD src repository

REVISION DETAIL
https://reviews.freebsd.org/D9246

EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/

To: fabient, jhb, gnn, stevek, jtl
Cc: imp

[stevek]

There's also the problem that this will still have issues when dealing with re-root and/or chroot environments.