Page MenuHomeFreeBSD
Differential D9132

Make EFI_RESERVED_SERVICE a proper prototype
ClosedPublic
Actions

Authored by dim on Jan 11 2017, 8:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 17, 11:50 PM
Unknown Object (File)
Fri, Oct 17, 5:57 AM
Unknown Object (File)
Sat, Oct 4, 2:36 PM
Unknown Object (File)
Sep 14 2025, 9:42 AM
Unknown Object (File)
Sep 14 2025, 12:13 AM
Unknown Object (File)
Sep 12 2025, 2:00 AM
Unknown Object (File)
Sep 12 2025, 1:59 AM
Unknown Object (File)
Sep 11 2025, 11:54 PM
View All Files
Subscribers
None

Details

Reviewers
emaste
imp
smh
tsoome
Commits
rS312772: MFC r311932:
rS311932: Make EFI_RESERVED_SERVICE a proper prototype
Summary

With clang 4.0.0, the EFI API header causes the following warning:

In file included from /share/dim/src/freebsd/base/projects/clang400-import/sys/boot/efi/loader/bootinfo.c:43:
In file included from /share/dim/src/freebsd/base/projects/clang400-import/sys/boot/efi/loader/../include/efi.h:52:
/share/dim/src/freebsd/base/projects/clang400-import/sys/boot/efi/loader/../include/efiapi.h:534:32: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]
(EFIAPI *EFI_RESERVED_SERVICE) (
                               ^

Let's add VOID to make it into a real prototype. Alternatively, we
could use "...", but I don't think that is necessary.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dim updated this revision to Diff 23875.Jan 11 2017, 8:23 AM
dim retitled this revision from to Make EFI_RESERVED_SERVICE a proper prototype.
dim updated this object.
dim edited the test plan for this revision. (Show Details)
dim added reviewers: emaste, imp, tsoome.
dim added a reviewer: smh.Jan 11 2017, 7:45 PM
imp accepted this revision.Jan 11 2017, 7:49 PM
imp edited edge metadata.

This looks OK. DF fixed this with 'void' instead of 'VOID' FWIW.
Upstream still has this as (), which is clearly wrong.
Also, Upstream is a complicated relationship because upstream has been sliced, diced and fried so completely that's not a concern...

This revision is now accepted and ready to land.Jan 11 2017, 7:49 PM
emaste accepted this revision.Jan 11 2017, 7:50 PM
emaste edited edge metadata.
tsoome accepted this revision.Jan 11 2017, 7:52 PM
tsoome edited edge metadata.
dim added a comment.Jan 11 2017, 7:57 PM
In D9132#188924, @imp wrote:

This looks OK. DF fixed this with 'void' instead of 'VOID' FWIW.

VOID is what Windows-like code tends to use. They like their uppercase type names. :-) In the end it's just an alias for void, so it doesn't matter too much.

Closed by commit rS311932: Make EFI_RESERVED_SERVICE a proper prototype (authored by dim). · Explain WhyJan 11 2017, 7:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
boot/
efi/
include/
1 line

Diff 23900

View Options

head/sys/boot/efi/include/efiapi.h

Loading...