Page MenuHomeFreeBSD

Make EFI_RESERVED_SERVICE a proper prototype
ClosedPublic

Authored by dim on Jan 11 2017, 8:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 10:02 PM
Unknown Object (File)
Thu, May 2, 10:02 PM
Unknown Object (File)
Thu, May 2, 9:11 PM
Unknown Object (File)
Thu, May 2, 8:35 PM
Unknown Object (File)
Apr 2 2024, 7:42 PM
Unknown Object (File)
Apr 2 2024, 5:58 PM
Unknown Object (File)
Mar 3 2024, 7:31 AM
Unknown Object (File)
Mar 3 2024, 7:08 AM
Subscribers
None

Details

Summary

With clang 4.0.0, the EFI API header causes the following warning:

In file included from /share/dim/src/freebsd/base/projects/clang400-import/sys/boot/efi/loader/bootinfo.c:43:
In file included from /share/dim/src/freebsd/base/projects/clang400-import/sys/boot/efi/loader/../include/efi.h:52:
/share/dim/src/freebsd/base/projects/clang400-import/sys/boot/efi/loader/../include/efiapi.h:534:32: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]
(EFIAPI *EFI_RESERVED_SERVICE) (
                               ^

Let's add VOID to make it into a real prototype. Alternatively, we
could use "...", but I don't think that is necessary.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dim retitled this revision from to Make EFI_RESERVED_SERVICE a proper prototype.
dim updated this object.
dim edited the test plan for this revision. (Show Details)
dim added reviewers: emaste, imp, tsoome.
imp edited edge metadata.

This looks OK. DF fixed this with 'void' instead of 'VOID' FWIW.
Upstream still has this as (), which is clearly wrong.
Also, Upstream is a complicated relationship because upstream has been sliced, diced and fried so completely that's not a concern...

This revision is now accepted and ready to land.Jan 11 2017, 7:49 PM
emaste edited edge metadata.
tsoome edited edge metadata.
In D9132#188924, @imp wrote:

This looks OK. DF fixed this with 'void' instead of 'VOID' FWIW.

VOID is what Windows-like code tends to use. They like their uppercase type names. :-) In the end it's just an alias for void, so it doesn't matter too much.

This revision was automatically updated to reflect the committed changes.