Page MenuHomeFreeBSD
Differential D8879

Move llvm-objdump from CLANG_EXTRAS to installed by default
ClosedPublic
Actions

Authored by emaste on Dec 21 2016, 5:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 9, 11:11 PM
Unknown Object (File)
Wed, Nov 27, 12:01 PM
Unknown Object (File)
Sat, Nov 23, 11:30 AM
Unknown Object (File)
Nov 21 2024, 5:47 PM
Unknown Object (File)
Nov 17 2024, 5:40 AM
Unknown Object (File)
Nov 13 2024, 3:24 AM
Unknown Object (File)
Nov 11 2024, 10:02 PM
Unknown Object (File)
Nov 11 2024, 8:31 PM
View All Files
Subscribers
bapt
imp
jhb

Details

Reviewers
dim
emaste
Commits
rS316423: Update clang, llvm, lld, lldb, compiler-rt and libc++ to 4.0.0 release:
rS310840: Reapply 310775, now it also builds correctly if lldb is disabled:
rS310775: Move llvm-objdump from CLANG_EXTRAS to installed by default
Summary

We currently install three tools from binutils 2.17.50: as, ld, and objdump. Work is underway to migrate to a permissively-licensed tool-chain, with one goal being the retirement of binutils 2.17.50.

LLVM's llvm-objdump is intended to be compatible with GNU objdump although it is currently missing some options and may have formatting differences. Enable it by default for testing and further investigation. It may later be changed to install as /usr/bin/objdump, it becomes a fully viable replacement.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 23180.Dec 21 2016, 5:04 PM
emaste retitled this revision from to Move llvm-objdump from CLANG_EXTRAS to installed by default.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added a reviewer: dim.
emaste added subscribers: bapt, jhb, imp.
emaste added inline comments.
lib/clang/libllvm/Makefile
311–328 ↗(On Diff #23180)

Perhaps there's something clever that can be done so that these are built for the target tools but not the host clang build? Not sure it's worth the complexity.

dim updated this revision to Diff 23242.Dec 24 2016, 7:46 PM
dim updated this object.
dim edited edge metadata.

Add a bit of extra logic to minimize the number of object files.

Use SRC_MIW to indicate minimal sources for the "world" stage.
Similarly, SRC_XDW for world with clang extras and lldb.

dim added a reviewer: emaste.Dec 24 2016, 7:47 PM

@emaste this works for me, but if you can try it out, please do. :)

emaste edited edge metadata.Dec 27 2016, 6:01 PM

Testing your version now

emaste added a comment.Dec 27 2016, 9:00 PM

SRC_MIW/SRC_XDW version looks good to me

emaste accepted this revision.Dec 27 2016, 9:01 PM
emaste edited edge metadata.
This revision is now accepted and ready to land.Dec 27 2016, 9:01 PM
Closed by commit rS310775: Move llvm-objdump from CLANG_EXTRAS to installed by default (authored by dim). · Explain WhyDec 29 2016, 1:27 PM
This revision was automatically updated to reflect the committed changes.
emaste mentioned this in D15837: Rework WITHOUT_LLD/TOOLCHAIN fix from r327892 for cross-tools..Jun 19 2018, 2:19 AM

Revision Contents
Changeset List

PathSize
head/
lib/
clang/
libllvm/
46 lines
usr.bin/
clang/
3 lines

Diff 23401

View Options

head/lib/clang/libllvm/Makefile

Loading...
View Options

head/usr.bin/clang/Makefile

Loading...