Page MenuHomeFreeBSD

Update devel/kdesvn-kde4 to 2.0.0 -> devel/kdesvn
ClosedPublic

Authored by tcberner on Dec 15 2016, 7:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 4:06 PM
Unknown Object (File)
Nov 19 2024, 10:49 PM
Unknown Object (File)
Nov 19 2024, 6:33 PM
Unknown Object (File)
Nov 13 2024, 4:16 AM
Unknown Object (File)
Nov 9 2024, 8:13 PM
Unknown Object (File)
Nov 8 2024, 9:32 AM
Unknown Object (File)
Oct 5 2024, 3:12 AM
Unknown Object (File)
Oct 2 2024, 1:56 AM
Subscribers

Details

Reviewers
dbn
adridg
rakuco
mat
Group Reviewers
kde
Summary
  • Update to 2.0.0 (from kdelibs4 to kf5)
  • Rename it to devel/kdesvn

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 6266
Build 6509: arc lint + arc unit

Event Timeline

tcberner retitled this revision from to Update devel/kdesvn-kde4 to 2.0.0 -> devel/kdesvn.
tcberner updated this object.
tcberner edited the test plan for this revision. (Show Details)
tcberner added reviewers: kde, rakuco, mat, adridg.

Btw, this is based on the port in plasma5/PORT/devel/kdesvn [1] .
I think there is no point in having kdesvn-kde4 and kdesvn-kf5. So I just renamed them.

[1] http://src.mouf.net/area51/browse/branches/plasma5/PORTS/devel/kdesvn

Fix build on 9.3 by using compiler:c++11-lib

dbn added a reviewer: dbn.
dbn added a subscriber: dbn.

Please check that the bookmark dialogs work (see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211769). Happy for @kde to take over maintainership.

This revision is now accepted and ready to land.Dec 17 2016, 8:20 AM

You are missing the correct MOVED entries. Note that there was a kdesvn port at one port that was depreciated. I should have updated that to link to the kdesvn-kde4 port.

Reminder: repo-copy to required from kdesvn-kde4 to kdesvn.

devel/kdesvn/Makefile
1

Shouldn't the original "Created by" be kept (even though there were various renamed on the way).

In D8811#182695, @dbn wrote:

Please check that the bookmark dialogs work (see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211769). Happy for @kde to take over maintainership.

Oops sorry, for the silent takeover :)

In D8811#182695, @dbn wrote:

Please check that the bookmark dialogs work (see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211769). Happy for @kde to take over maintainership.

The issue here is bin/keditbookmarks which is provided by x11/kde4-baseapps in kde4.
I'll have to attach an other freshly baked port to this diff to make the edit-dialog work in the kf5 version:
deskutils/keditbookmarks-kf5 [1].

Which requires me to first prepare kde.mk somewhat... consider this diff 'on hold' :D

[1] http://src.mouf.net/area51/revision/?rev=13483

Also, this requiring deskutils/kbookmarksdialog-kf5 would make this conflict with kde4-baseapps. So this is blocked until we update the KDE desktop :/

This will be done differently after D12932