Differential D876

Remove MK_ARM_EABI
ClosedPublic
Actions

Authored by andrew on Sep 30 2014, 2:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Oct 26 2024, 2:36 PM

	Unknown Object (File)
	Oct 26 2024, 2:35 PM

	Unknown Object (File)
	Oct 26 2024, 2:35 PM

	Unknown Object (File)
	Oct 26 2024, 2:18 PM

	Unknown Object (File)
	Oct 9 2024, 4:42 AM

	Unknown Object (File)
	Oct 6 2024, 1:47 AM

	Unknown Object (File)
	Oct 3 2024, 4:59 AM

	Unknown Object (File)
	Oct 3 2024, 1:09 AM

View All 98 Files

Subscribers

Details

Reviewers

rpaulo
bdrewery

Group Reviewers

Commits

rS272350: Remove MK_ARM_EABI, the armeb issues have been fixed. The code to support

Test Plan

tinderbox passes

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

andrew updated this revision to Diff 1848.Sep 30 2014, 2:01 PM

andrew retitled this revision from to Remove MK_ARM_EABI.

andrew updated this object.

andrew edited the test plan for this revision. (Show Details)

andrew added a reviewer: ARM.

Herald added a reviewer: bdrewery. · View Herald TranscriptSep 30 2014, 2:01 PM

andrew added inline comments.Sep 30 2014, 2:03 PM

sys/arm/arm/syscall.c
1 ↗	(On Diff #1848)	Ignore this file, it's part of an unrelated change

rpaulo accepted this revision.Sep 30 2014, 2:47 PM

rpaulo added a reviewer: rpaulo.

rpaulo added a subscriber: rpaulo.

rpaulo added inline comments.

sys/conf/Makefile.arm
45 ↗	(On Diff #1848)	Ugh, nasty bug.

This revision is now accepted and ready to land.Sep 30 2014, 2:47 PM

Found the same thing as rpaulo, and another. There appears to be lots of copying for the compiler library run time support in a few places in the tree that would be good to clean up, but that's likely beyond the scope of this thing patch-set.

lib/clang/clang.build.mk
25 ↗	(On Diff #1848)	Shouldn't this include armeb either defaulting to the gnueabi, or as a .warning "You lose"?
sys/boot/libstand32/Makefile
70 ↗	(On Diff #1848)	Just an aside: We have similar logic in lots of places.... might be a good place to consolidate / refactor.
sys/conf/Makefile.arm
45 ↗	(On Diff #1848)	Yea, fun times... Where does DDB_ENABLED get defined?

andrew added inline comments.Sep 30 2014, 4:20 PM

lib/clang/clang.build.mk
25 ↗	(On Diff #1848)	There is no support for armeb in llvm.
sys/conf/Makefile.arm
45 ↗	(On Diff #1848)	At the end of kern.pre.mk

In D876#12, @andrew wrote:

No support for armeb in clang

Do we .error it out somewhere else? If not, we should do so here. A quick grep doesn't show a global filter... Alternatively, we should try to get it right, even if other things fail. We shouldn't do something we know is wrong because it isn't supported.

emaste added a subscriber: emaste.Sep 30 2014, 8:52 PM

emaste added inline comments.

lib/clang/clang.build.mk
25 ↗	(On Diff #1848)	There is support for armeb in upstream Clang/LLVM (although I'm unsure of the quality / completeness); presumably it will become viable upon a future import.

Closed by commit rS272350 (authored by @andrew).

I'm committing this as is, and cleaning up the issues in a later commit.

andrew closed this revision.Oct 1 2014, 1:57 PM

Revision Contents
Changeset List

Path

Size

head/

2 lines

gnu/

lib/

csu/

2 lines

libgcc/

10 lines

libgcov/

2 lines

libstdc++/

5 lines

libsupc++/

5 lines

usr.bin/

cc/

2 lines

cc_tools/

4 lines

lib/

clang/

3 lines

libc/

arm/

5 lines

Symbol_oabi.map

16 lines

gen/

4 lines

quad/

2 lines

libcompiler_rt/

5 lines

libstand/

4 lines

libexec/

rtld-elf/

2 lines

share/

mk/

1 line

sys/

boot/

arm/

ixp425/

boot2/

2 lines

libstand32/

4 lines

conf/

6 lines

1 line

Diff 1850

head/Makefile.inc1

Loading...

head/gnu/lib/csu/Makefile

Loading...

head/gnu/lib/libgcc/Makefile

Loading...

head/gnu/lib/libgcov/Makefile

Loading...

head/gnu/lib/libstdc++/Makefile

Loading...

head/gnu/lib/libsupc++/Makefile

Loading...

head/gnu/usr.bin/cc/Makefile.inc

Loading...

head/gnu/usr.bin/cc/cc_tools/Makefile

Loading...

head/lib/clang/clang.build.mk

Loading...

head/lib/libc/arm/Makefile.inc

Loading...

head/lib/libc/arm/Symbol_oabi.map

Loading...

head/lib/libc/arm/gen/Makefile.inc

Loading...

head/lib/libc/quad/Makefile.inc

Loading...

head/lib/libcompiler_rt/Makefile

Loading...

head/lib/libstand/Makefile

Loading...

head/libexec/rtld-elf/Makefile

Loading...

head/share/mk/src.opts.mk

Loading...

head/sys/boot/arm/ixp425/boot2/Makefile

Loading...

head/sys/boot/libstand32/Makefile

Loading...

head/sys/conf/Makefile.arm

Loading...

head/sys/conf/kern.opts.mk

Loading...