Page MenuHomeFreeBSD

Remove MK_ARM_EABI
ClosedPublic

Authored by andrew on Sep 30 2014, 2:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 19, 2:50 AM
Unknown Object (File)
Tue, May 7, 2:55 PM
Unknown Object (File)
Apr 21 2024, 7:44 AM
Unknown Object (File)
Feb 26 2024, 4:41 PM
Unknown Object (File)
Dec 19 2023, 9:23 PM
Unknown Object (File)
Nov 15 2023, 5:49 PM
Unknown Object (File)
Nov 9 2023, 2:10 PM
Unknown Object (File)
Nov 7 2023, 9:21 PM
Subscribers

Details

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

andrew retitled this revision from to Remove MK_ARM_EABI.
andrew updated this object.
andrew edited the test plan for this revision. (Show Details)
andrew added a reviewer: ARM.
sys/arm/arm/syscall.c
1

Ignore this file, it's part of an unrelated change

rpaulo added a reviewer: rpaulo.
rpaulo added a subscriber: rpaulo.
rpaulo added inline comments.
sys/conf/Makefile.arm
45

Ugh, nasty bug.

This revision is now accepted and ready to land.Sep 30 2014, 2:47 PM

Found the same thing as rpaulo, and another. There appears to be lots of copying for the compiler library run time support in a few places in the tree that would be good to clean up, but that's likely beyond the scope of this thing patch-set.

lib/clang/clang.build.mk
25

Shouldn't this include armeb either defaulting to the gnueabi, or as a .warning "You lose"?

sys/boot/libstand32/Makefile
70

Just an aside: We have similar logic in lots of places.... might be a good place to consolidate / refactor.

sys/conf/Makefile.arm
45

Yea, fun times... Where does DDB_ENABLED get defined?

lib/clang/clang.build.mk
25

There is no support for armeb in llvm.

sys/conf/Makefile.arm
45

At the end of kern.pre.mk

In D876#12, @andrew wrote:

No support for armeb in clang

Do we .error it out somewhere else? If not, we should do so here. A quick grep doesn't show a global filter... Alternatively, we should try to get it right, even if other things fail. We shouldn't do something we know is wrong because it isn't supported.

emaste added inline comments.
lib/clang/clang.build.mk
25

There is support for armeb in upstream Clang/LLVM (although I'm unsure of the quality / completeness); presumably it will become viable upon a future import.

andrew updated this revision to Diff 1850.

Closed by commit rS272350 (authored by @andrew).

I'm committing this as is, and cleaning up the issues in a later commit.