remove network mask calculation for Classful network

[kczekirda]

Summary

Nowadays it's not necessary to compute network mask from the IP address and compare to given by DHCP.

[tsoome]

There is an problem - not enough context. You can use arcanist, or just tell svn diff to include more {all} lines.

[tsoome]

IMO it seems to make sense, but there is the question, how much testing have you done, any class[less] tests?

[kczekirda]

Tested on:

• 192.168.1.0/24
• 192.168.1.0/25
• 10.0.0.0/16
• 10.0.0.0/24
• 176.119.56.0/22

[tsoome]

Seems good, I think.

[glebius]

This revision will make BOOTP incompatible towards old classful BOOTP server. If a BOOTP server doesn't supply mask at all, you will end with zero mask.

Of course, the class mask shall not override mask supplied from server. But support for classes should remain, it doesn't hurt. So, the whole code removed should remain, but wrapped into "if (!smask) { }".

[kczekirda]

It's should enough for backwards compatibility.

[glebius]

This looks correct to me. But I haven't reviewed the consequences of writing directly to the "netmask", which is also shared with rarp.c and udp.c

Thanks!