Document support for Terminator 6 adapters in cxgbe(4) and cxgbev(4).
Details
Details
- Reviewers
np - Group Reviewers
manpages - Commits
- rS309581: Document support for Terminator 6 adapters in cxgbe(4) and cxgbev(4).
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Similar updates for cxgbev.4 as for cxgbe.4.
| share/man/man4/cxgbe.4 | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 39 ↗ | (On Diff #22722) | Isn't there also a 50Gb option? | ||||||||||||||||||||
| 80 ↗ | (On Diff #22722) | I think something like this might be clearer:
| ||||||||||||||||||||
| 172 ↗ | (On Diff #22722) | s/higher-speed/faster/g ? | ||||||||||||||||||||
Comment Actions
Ah, you already submitted. Well then, please consider these comments as enhancement requests, and/or ignore them. :-)
| share/man/man4/cxgbe.4 | ||
|---|---|---|
| 39 ↗ | (On Diff #22722) | Hmmm, the card descriptions in the source seemed to refer to 10/25 cards (SFP+ I think) and 40/100 cards (QSFP?) I did see some references to 50 in the latest firmware commit that I think impled it was also QSFP? To some extent the list of speeds here is getting unwieldy and I almost wonder if it wouldn't be better to use something more generic like "Chelsio T4-, T5-, and T6-based high performance Ethernet adapter driver". |
| 80 ↗ | (On Diff #22722) | So there is also at least one hw.cxl tunable which applies to T5 and later (for using WC mapping of BAR2). It's not currently documented in this page of course, but that appears to be the model for how those names work (so not quite 1:1 for tunable prefixes). It would be nice one day to have all the tunables show up as read-only sysctls as well. |
| 172 ↗ | (On Diff #22722) | I debated changing this to "non-1GB port" as that would be shorter. Higher-speed seemed "natural" to me compared to faster. Also, I'm not sure what a SFP+ using a 1GB optic ends up using. I suspect it gets treated as a "high-speed" port. If so, that would seem to possibly define these as "number of queues for a 1Gb RJ45 port" and "number of queues for a non-1GB RJ45 port". |
| share/man/man4/cxgbe.4 | ||
|---|---|---|
| 83 ↗ | (On Diff #22722) | passive->active: s/will provide/provides/ |
| 85 ↗ | (On Diff #22722) | passive->active: s/will use/use/ |
| 172 ↗ | (On Diff #22722) | "Higher-speed" is more specific. Or less ambiguous. For example, a port that is rated at a lower speed might actually have faster transfers (due to any number of things). |
| 172 ↗ | (On Diff #22722) | Also: passive->active: s/to use/used/ Of course, these are all like that, so it would be a much larger change to make them consistent. In some recent review, possibly this one, I suggested that removing the leading "The" can make these into items rather than sentences. It removes some redundancy and can make these easier to read. For example: .It Va hw.cxgbe.ntxq10g |