Fix booting the arm64 kernel when built with clang 3.9.0
ClosedPublic
Actions

Authored by andrew on Nov 23 2016, 11:45 AM.

Details

Reviewers

bapt

Commits

rP428028: MFH: r427378
rP427378: Fix booting the arm64 kernel when built with clang 3.9.0

Summary

Clang 3.9.0 changes how weak extern is handled. They now use the got to
handle them. This is a problem as ld.bfd doesn't fill out any default
value in the got so pointers become NULL. This caused the kernel to fail
to boot as we use this in linker sets.

This fixes the issue by setting s default value in the got. The kernel
still loads data through it, but because we always load it at a fixed virtual
address the address it finds is valid.

There is an LLVM bug with some background information at the following,
however I think this is in fact a binutils bug the change in behaviour has
found.
https://llvm.org/bugs/show_bug.cgi?id=30848

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew updated this revision to Diff 22460.Nov 23 2016, 11:45 AM

andrew retitled this revision from to Fix booting the arm64 kernel when built with clang 3.9.0.

andrew updated this object.

andrew edited the test plan for this revision. (Show Details)

andrew added a reviewer: bapt.

andrew added subscribers: emaste, dim.

Herald added a subscriber: mat. · View Herald TranscriptNov 23 2016, 11:45 AM

Post this for upstream binutils also? @jhb can commit it there if it's approved.

I'm not sure this is the correct fix for upstream. I don't think ld should be generating relocations for weak extern pointing at these linker sets, however that would need someone that knows more about ld internals than I do.