Page MenuHomeFreeBSD

Use capsicum helpers widely.
ClosedPublic

Authored by oshogbo on Oct 3 2016, 8:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 3:58 AM
Unknown Object (File)
Sat, Apr 20, 3:56 AM
Unknown Object (File)
Mar 8 2024, 3:26 AM
Unknown Object (File)
Feb 12 2024, 1:07 PM
Unknown Object (File)
Feb 1 2024, 10:56 PM
Unknown Object (File)
Jan 3 2024, 5:41 PM
Unknown Object (File)
Dec 27 2023, 5:35 PM
Unknown Object (File)
Dec 27 2023, 5:09 PM
Subscribers
None

Details

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

oshogbo retitled this revision from to Use capsicum helpers widely..
oshogbo updated this object.
oshogbo edited the test plan for this revision. (Show Details)
oshogbo added reviewers: cem, allanjude, ed, emaste, bapt.
ed edited edge metadata.
This revision is now accepted and ready to land.Oct 3 2016, 8:05 PM

For future uploads can you please include context (e.g. git diff -U9999)

usr.bin/cmp/cmp.c
167–170

I think we should generally combine these into one error, e.g. "unable to limit stdio rights". Unless there's some action the user can take based on knowing if it was stdout or stderr that failed, there's no real value in differentiating them.

oshogbo edited edge metadata.

@emaste Sure.
Fix checks.

This revision now requires review to proceed.Oct 3 2016, 8:27 PM
oshogbo edited edge metadata.

Fix one more string error.

cem edited edge metadata.
cem added inline comments.
usr.bin/elfdump/elfdump.c
575–576

This drops the zero-capability restriction of stdin.

This revision is now accepted and ready to land.Oct 3 2016, 8:47 PM
oshogbo edited edge metadata.

Limit STDIN in elfdump as @cem suggested.

This revision now requires review to proceed.Oct 3 2016, 9:06 PM
cem edited edge metadata.
cem added inline comments.
usr.bin/elfdump/elfdump.c
576–577

Seems odd to mix < 0 and == -1 checks in one if.

This revision is now accepted and ready to land.Oct 3 2016, 9:41 PM
bapt edited edge metadata.
emaste edited edge metadata.

I could see future tweaks in some of these but I think this is a good cleanup