Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
For future uploads can you please include context (e.g. git diff -U9999)
usr.bin/cmp/cmp.c | ||
---|---|---|
167–170 | I think we should generally combine these into one error, e.g. "unable to limit stdio rights". Unless there's some action the user can take based on knowing if it was stdout or stderr that failed, there's no real value in differentiating them. |
usr.bin/elfdump/elfdump.c | ||
---|---|---|
575–576 | This drops the zero-capability restriction of stdin. |
usr.bin/elfdump/elfdump.c | ||
---|---|---|
576–577 | Seems odd to mix < 0 and == -1 checks in one if. |