Page MenuHomeFreeBSD
Differential D7763

Introduce support for Annapurna Alpine SerDes
ClosedPublic
Actions

Authored by mst_semihalf.com on Sep 2 2016, 5:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 12:03 PM
Unknown Object (File)
Wed, Nov 20, 4:05 PM
Unknown Object (File)
Tue, Nov 19, 4:20 PM
Unknown Object (File)
Wed, Nov 6, 7:28 PM
Unknown Object (File)
Tue, Nov 5, 2:28 PM
Unknown Object (File)
Mon, Nov 4, 10:15 PM
Unknown Object (File)
Thu, Oct 24, 12:02 AM
Unknown Object (File)
Oct 17 2024, 11:33 AM
View All Files
Subscribers
andrew
emaste
ARM
arm64

Details

Reviewers
wma
imp
• ian
Commits
rS307669: Support for Alpine Serializer/Deserializer.
Summary

Support for Alpine Serializer/Deserializer. The exported functions will be used by Alpine Ethernet driver.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mst_semihalf.com updated this revision to Diff 19985.Sep 2 2016, 5:27 PM
mst_semihalf.com retitled this revision from to Introduce support for Annapurna Alpine SerDes.
mst_semihalf.com updated this object.
mst_semihalf.com edited the test plan for this revision. (Show Details)
mst_semihalf.com added reviewers: • ian, imp, wma.
mst_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.
mst_semihalf.com added subscribers: ARM, arm64.
Herald added a subscriber: andrew. · View Herald TranscriptSep 2 2016, 5:27 PM
wma added inline comments.Sep 5 2016, 6:26 AM
sys/arm/annapurna/alpine/alpine_serdes.c
117 ↗(On Diff #19985)

Mutexes are never destroyed. Are they required to be global or can we hide them all inside softc?

sys/arm/annapurna/alpine/alpine_serdes.h
26 ↗(On Diff #19985)
  • $FreeBSD$
mst_semihalf.com updated this revision to Diff 20062.Sep 5 2016, 5:25 PM

Add $FreeBSD$, cleanup mutex locks in detach(), check if mtx is initialized before calling lock/unlock.

mst_semihalf.com added inline comments.Sep 5 2016, 5:32 PM
sys/arm/annapurna/alpine/alpine_serdes.c
117 ↗(On Diff #19985)

Now they're destroyed in detach(). I think it would be better to leave them in the global array as we need to access them in the exported functions where there is no way to retrieve softc.

sys/arm/annapurna/alpine/alpine_serdes.h
26 ↗(On Diff #19985)

Fixed

mst_semihalf.com updated this revision to Diff 20144.Sep 7 2016, 3:47 PM

Add missing Serdes DTS node and include the driver in files.arm and files.arm64.

Herald added a subscriber: emaste. · View Herald TranscriptSep 7 2016, 3:47 PM
mst_semihalf.com updated this revision to Diff 21529.Oct 20 2016, 11:04 AM

Rebase to latest HEAD

wma accepted this revision.Oct 20 2016, 11:26 AM
wma edited edge metadata.
This revision is now accepted and ready to land.Oct 20 2016, 11:26 AM
Closed by commit rS307669: Support for Alpine Serializer/Deserializer. (authored by wma). · Explain WhyOct 20 2016, 11:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
arm/
annapurna/
alpine/
61 lines
225 lines
boot/
fdt/
dts/
arm/
6 lines
conf/
3 lines
3 lines

Diff 21534

View Options

head/sys/arm/annapurna/alpine/alpine_serdes.h

Loading...
View Options

head/sys/arm/annapurna/alpine/alpine_serdes.c

Loading...
View Options

head/sys/boot/fdt/dts/arm/annapurna-alpine.dts

Loading...
View Options

head/sys/conf/files.arm

Loading...
View Options

head/sys/conf/files.arm64

Loading...