Page MenuHomeFreeBSD

Introduce support for Annapurna Alpine SerDes
ClosedPublic

Authored by mst_semihalf.com on Sep 2 2016, 5:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 24 2024, 10:04 AM
Unknown Object (File)
Feb 21 2024, 6:56 PM
Unknown Object (File)
Jan 10 2024, 4:41 AM
Unknown Object (File)
Dec 27 2023, 7:52 PM
Unknown Object (File)
Dec 27 2023, 7:49 PM
Unknown Object (File)
Dec 27 2023, 7:49 PM
Unknown Object (File)
Dec 27 2023, 7:49 PM
Unknown Object (File)
Dec 20 2023, 12:35 AM

Details

Summary

Support for Alpine Serializer/Deserializer. The exported functions will be used by Alpine Ethernet driver.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mst_semihalf.com retitled this revision from to Introduce support for Annapurna Alpine SerDes.
mst_semihalf.com updated this object.
mst_semihalf.com edited the test plan for this revision. (Show Details)
mst_semihalf.com added reviewers: ian, imp, wma.
mst_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.
mst_semihalf.com added subscribers: ARM, arm64.
sys/arm/annapurna/alpine/alpine_serdes.c
117 ↗(On Diff #19985)

Mutexes are never destroyed. Are they required to be global or can we hide them all inside softc?

sys/arm/annapurna/alpine/alpine_serdes.h
26 ↗(On Diff #19985)
  • $FreeBSD$

Add $FreeBSD$, cleanup mutex locks in detach(), check if mtx is initialized before calling lock/unlock.

sys/arm/annapurna/alpine/alpine_serdes.c
117 ↗(On Diff #19985)

Now they're destroyed in detach(). I think it would be better to leave them in the global array as we need to access them in the exported functions where there is no way to retrieve softc.

sys/arm/annapurna/alpine/alpine_serdes.h
26 ↗(On Diff #19985)

Fixed

Add missing Serdes DTS node and include the driver in files.arm and files.arm64.

wma edited edge metadata.
This revision is now accepted and ready to land.Oct 20 2016, 11:26 AM
This revision was automatically updated to reflect the committed changes.