Page MenuHomeFreeBSD

Don't fail disk state change if g_mirror_clear_metadata() fails.
ClosedPublic

Authored by markj on Sep 1 2016, 9:24 PM.
Tags
None
Referenced Files
F107839003: D7750.diff
Sat, Jan 18, 3:46 PM
Unknown Object (File)
Wed, Jan 8, 4:17 AM
Unknown Object (File)
Nov 10 2024, 11:03 PM
Unknown Object (File)
Sep 24 2024, 3:40 AM
Unknown Object (File)
Sep 16 2024, 12:58 PM
Unknown Object (File)
Sep 2 2024, 12:00 AM
Unknown Object (File)
Aug 29 2024, 4:01 PM
Unknown Object (File)
Aug 18 2024, 1:10 AM
Subscribers

Details

Summary

We may fail to clear the metadata if we attempt to remove the disk from
the mirror as it is being destroyed, e.g. because of a concurrent hot
swap. This is not a fatal error since a failure from
g_mirror_clear_metadata() will result in the mirror's generation ID
being bumped, so the disk in question will not be added back into the
mirror upon a retaste.

Without this change, INVARIANTS kernels will panic in this case
because the mirror worker won't handle errors.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj retitled this revision from to Don't fail disk state change if g_mirror_clear_metadata() fails..
markj edited the test plan for this revision. (Show Details)
markj updated this object.

Do we have a good way to unit test this so I can add a relevant gmirror testcase?

This revision was automatically updated to reflect the committed changes.