Page MenuHomeFreeBSD
Differential D7548

Remove the obsolete openbsd_poll system call.
ClosedPublic
Actions

Authored by gnn on Aug 17 2016, 12:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 11:57 PM
Unknown Object (File)
Wed, Dec 18, 2:13 AM
Unknown Object (File)
Fri, Dec 6, 10:08 AM
Unknown Object (File)
Sat, Nov 23, 11:50 PM
Unknown Object (File)
Sat, Nov 23, 10:37 AM
Unknown Object (File)
Sat, Nov 23, 7:57 AM
Unknown Object (File)
Nov 22 2024, 7:24 AM
Unknown Object (File)
Nov 21 2024, 12:18 PM
View All Files
Subscribers
andrew
emaste
imp

Details

Reviewers
brooks
jhb
Commits
rS304402: Remove the obsolete and unused openbsd_poll system call. (Phase 2)
rS304395: Remove unusedd and obsolete openbsd_poll system call. (Phase 1)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4837
Build 4900: arc lint + arc unit

Event Timeline

gnn updated this revision to Diff 19412.Aug 17 2016, 12:29 PM
gnn retitled this revision from to Remove the obsolete openbsd_poll system call..
gnn updated this object.
gnn edited the test plan for this revision. (Show Details)
Herald added a subscriber: imp. · View Herald TranscriptAug 17 2016, 12:29 PM
gnn added reviewers: brooks, jhb.Aug 17 2016, 12:29 PM
emaste added a subscriber: emaste.Aug 17 2016, 12:32 PM
brooks edited edge metadata.Aug 17 2016, 12:48 PM

You'll also want to remove the mention of openbsd_poll.o from src/lib/libc/<arch>/sys/Makefile.inc. Because this is there, there isn't any normal way this syscall could be called be existing code.

gnn updated this revision to Diff 19414.Aug 17 2016, 1:14 PM
gnn edited edge metadata.

Address issues pointed out by brooks@

Herald added a subscriber: andrew. · View Herald TranscriptAug 17 2016, 1:14 PM
jhb accepted this revision.Aug 17 2016, 1:45 PM
jhb edited edge metadata.

Humm, we never put this in Symbol.map. Not sure why Peter added it back in 1997 either. Please do the regen after committing

This revision is now accepted and ready to land.Aug 17 2016, 1:45 PM
gnn updated this revision to Diff 19446.Aug 18 2016, 10:33 AM
gnn edited edge metadata.

Add the version update

This revision now requires review to proceed.Aug 18 2016, 10:33 AM
Closed by commit rS304395: Remove unusedd and obsolete openbsd_poll system call. (Phase 1) (authored by gnn). · Explain WhyAug 18 2016, 10:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 19412

View Options

sys/compat/freebsd32/freebsd32_syscall.h

Loading...
View Options

sys/compat/freebsd32/freebsd32_syscalls.c

Loading...
View Options

sys/compat/freebsd32/freebsd32_sysent.c

Loading...
View Options

sys/compat/freebsd32/freebsd32_systrace_args.c

Loading...
View Options

sys/compat/freebsd32/syscalls.master

Loading...
View Options

sys/kern/capabilities.conf

Loading...
View Options

sys/kern/init_sysent.c

Loading...
View Options

sys/kern/sys_generic.c

Loading...
View Options

sys/kern/syscalls.c

Loading...
View Options

sys/kern/syscalls.master

Loading...
View Options

sys/kern/systrace_args.c

Loading...
View Options

sys/sys/syscall.h

Loading...
View Options

sys/sys/syscall.mk

Loading...
View Options

sys/sys/sysproto.h

Loading...