Page MenuHomeFreeBSD

tcp/lro: If timestamps mismatch or it's a FIN, force flush.
ClosedPublic

Authored by sepherosa_gmail.com on Aug 4 2016, 8:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 27 2017, 2:38 AM
Unknown Object (File)
Apr 5 2017, 11:54 AM
Unknown Object (File)
Feb 23 2017, 8:01 PM
Unknown Object (File)
Feb 23 2017, 7:47 PM
Unknown Object (File)
Feb 6 2017, 12:27 AM
Unknown Object (File)
Feb 6 2017, 12:21 AM
Unknown Object (File)
Feb 5 2017, 5:32 PM
Unknown Object (File)
Feb 5 2017, 11:27 AM
Subscribers

Details

Summary
This keeps the segments/ACK/FIN delivery order.

Before this patch, it was observed: if A sent FIN immediately after
an ACK, B would deliver FIN first to the TCP stack, then the ACK.
This out-of-order delivery causes one unnecessary ACK sent from B.

Obtained from:  gallatin, rrs

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sepherosa_gmail.com retitled this revision from to tcp/lro: If timestamps mismatch or it's a FIN, force flush..
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
sys/netinet/tcp_lro.c
852 ↗(On Diff #19031)

Should there be added:

if (force_flush)

return (TCP_LRO_CANNOT);

If no match is found in the list?

sys/netinet/tcp_lro.c
852 ↗(On Diff #19031)

Ah, yeah, it was in the original patch from rrs, got lost by me :P

Don't create entry for segments cant be further aggregated/delayed. Noticed-by: hps

hselasky edited edge metadata.

Looks good to me.

--HPS

gallatin edited edge metadata.
This revision was automatically updated to reflect the committed changes.