Page MenuHomeFreeBSD
Differential D7405

hyperv/storvsc: Enable TRIM support for Win2012R2
ClosedPublic
Actions

Authored by honzhan_microsoft.com on Aug 3 2016, 5:05 AM.
Tags
None
Referenced Files
F172619745: D7405.id.diff
Sat, Sep 19, 6:02 PM
F172546160: D7405.diff
Sat, Sep 19, 4:16 AM
Unknown Object (File)
Sat, Sep 12, 4:24 PM
Unknown Object (File)
Sat, Sep 12, 10:15 AM
Unknown Object (File)
Tue, Sep 8, 10:37 PM
Unknown Object (File)
Mon, Sep 7, 3:28 PM
Unknown Object (File)
Thu, Sep 3, 5:19 PM
Unknown Object (File)
Thu, Sep 3, 4:48 PM
View All Files
Subscribers
imp
Contributor Reviews (src)

Details

Reviewers
howard0su_gmail.com
decui_microsoft.com
hrs
delphij
sepherosa_gmail.com
royger
Commits
rS303737: hyperv/storvsc: Claim SPC-3 conformance, thus enable UNMAP support
Summary

On win8 and win2012 the inquiry response indicates the device is SPC-2, but in fact it is SPC-3.
This is a host issue and has fixed on win2016. FreeBSD VM has to manually set SCSI version to SPC-3 to support TRIM.

Submitted by: Hongjiang Zhang <honzhan microsoft com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

honzhan_microsoft.com updated this revision to Diff 18989.Aug 3 2016, 5:05 AM
honzhan_microsoft.com retitled this revision from to hyperv/storvsc: Enable TRIM support for Win2012R2.
honzhan_microsoft.com updated this object.
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptAug 3 2016, 5:05 AM
honzhan_microsoft.com updated this object.Aug 3 2016, 5:17 AM
honzhan_microsoft.com added reviewers: hrs, sepherosa_gmail.com, decui_microsoft.com, delphij, royger, howard0su_gmail.com.
sepherosa_gmail.com accepted this revision.Aug 3 2016, 5:27 AM
sepherosa_gmail.com edited edge metadata.

Fix the comment. Rest looks fine.

sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c
2162 ↗(On Diff #18989)

UNMAP?

This revision is now accepted and ready to land.Aug 3 2016, 5:27 AM
honzhan_microsoft.com added inline comments.Aug 3 2016, 5:29 AM
sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c
2162 ↗(On Diff #18989)

yes, UNMAP is the formal command.

honzhan_microsoft.com updated this revision to Diff 18990.Aug 3 2016, 5:35 AM
honzhan_microsoft.com edited edge metadata.
honzhan_microsoft.com removed rS FreeBSD src repository - subversion as the repository for this revision.
This revision now requires review to proceed.Aug 3 2016, 5:35 AM
sepherosa_gmail.com accepted this revision.Aug 3 2016, 5:49 AM
sepherosa_gmail.com edited edge metadata.
This revision is now accepted and ready to land.Aug 3 2016, 5:49 AM
Closed by commit rS303737: hyperv/storvsc: Claim SPC-3 conformance, thus enable UNMAP support (authored by sephe). · Explain WhyAug 4 2016, 5:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
hyperv/
storvsc/
23 lines

Diff 19027

View Options

head/sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c

Loading...